1
0
mirror of https://github.com/flarum/core.git synced 2025-07-16 06:16:23 +02:00
Commit Graph

1608 Commits

Author SHA1 Message Date
f6b1d65a57 Fix consecutive shows of same modal with different attrs
We need to specify a unique key for each modal so that the modals are fully destroyed and recreated. For instance, this fixes the signup modal being empty with OAuth register flows.
2021-12-27 18:28:11 -05:00
c939b4f274 Use translations for page titles in frontend
This gives more flexibility for customization, and allows overriding title structure via translations / linguist.
2021-12-27 18:15:12 -05:00
01e177eb52 Fix drawer focus trap making login form unclickable on mobile
Adding `clickOutsideDeactivates` seems to fix the issue, contrary to what the focus-trap documentation implies about it being unnecessary.
2021-12-26 22:45:58 -05:00
5e9f746f37 Fix Search error when user can't search
If there are no search sources, HTML for the Search component won't be rendered, so trying to attach listeners to it will likely error.

In this PR, we don't attach such listeners/logic if there are no sources. We also stop asserting that sources is defined to help avoid other similar issues in the future.
2021-12-26 20:04:48 -05:00
46d90487e8 Bundled output for commit 343f822771
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-22 18:58:42 +00:00
343f822771 fix: hide WelcomeHero when content is empty (#3219) 2021-12-22 13:54:21 -05:00
4ac6887c6f Bundled output for commit e9de3f3c61
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-20 16:32:17 +00:00
e9de3f3c61 fix: breaking change in Search component - renaming of state property (#3212)
* fix: breaking change in search component's public api

* fix: add setter

* feat: add deprecation warning helper

This reduces bundle size as a result of deprecation warning in our JS, as well as maintaining a consistent format across warnings.

* feat: fire deprecation warning on usage of `Search.state`

* chore: use consistent deprecation warning across core

* fix: `/pull` not `/issue`

* chore: format
2021-12-20 16:28:28 +00:00
5ddfacf436 fix(postmeta): use app baseUrl instead of location.origin (#3216) 2021-12-20 16:25:04 +00:00
c8febb6199 Bundled output for commit 93e7b446bd
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-16 08:36:25 +00:00
93e7b446bd fix: Add a11y labels to auth modal inputs (#3207) 2021-12-16 09:30:34 +01:00
6a90930373 Bundled output for commit eeff1e5b65
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-15 15:53:25 +00:00
eeff1e5b65 fix: replace throw with debug warning to fix breaking change (#3206)
* fix: replace throw with debug warning to fix breaking change

* Add link back to PR in warning

* fix: add missing `return null` for `!allowUnregistered` code path

* Clean up message -- move more info to PR comment

* Add setTimeout to delay call debug warning call until after `app.forum` is defined

* Add backticks around data type
2021-12-15 10:48:46 -05:00
1c2a33b253 Bundled output for commit 8fa7ffa175
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-14 22:16:16 +00:00
8fa7ffa175 feat: extract notification primaryControl items to an ItemList (#3204) 2021-12-14 22:11:48 +00:00
6a5afd1e4f Bundled output for commit 56809ae20b
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-14 17:10:20 +00:00
56809ae20b Merge pull request #2961 from the-turk/style-st
Improve selected text stylization
2021-12-14 12:06:22 -05:00
1efab83293 Bundled output for commit 3d754461b0
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-14 03:11:57 +00:00
a82a160ecb Format and Type Import Cleanup
Co-authored-by: David Wheatley <hi@davwheat.dev>
2021-12-13 22:04:36 -05:00
7b8eaf9045 Fix typing errors with app.modal.show
Unfortunately TypeScript doesn't support higher-kinded types, so we can't write this in a type-safe way.
2021-12-13 20:20:35 -05:00
850d555866 Slightly improve AlertManagerState show typing
`typeof Alert` is more correct than `Alert`, since we're accepting classes not instances.
2021-12-13 20:20:35 -05:00
7b8d507139 VnodeElementTag must be either a string or a class.
Unfortunately, TypeScript only supports strings and classes for JSX tags.
Therefore, our type definition should only allow for those two types.
see https://github.com/microsoft/TypeScript/issues/14789#issuecomment-412247771
2021-12-13 20:20:34 -05:00
959662f2e2 Format VnodeElementTag fix 2021-12-13 20:20:34 -05:00
e1c6028dce Modal typescript cleanup and conversions 2021-12-13 20:20:34 -05:00
da6ae898b2 alertAttrs can be null 2021-12-13 20:20:34 -05:00
74f223cccc Fix LoadingModal attr typings 2021-12-13 20:20:34 -05:00
0e2053da1f Allow any Mithril Children where appropriate 2021-12-13 20:20:33 -05:00
d307331603 extractText from translations where strings expected 2021-12-13 20:20:33 -05:00
a8db0b7bb2 Fix import of mithril for VnodeElementTag usage 2021-12-13 20:20:33 -05:00
e79d3bc3b7 Don't assume app.session.user is present 2021-12-13 20:20:33 -05:00
32d272c57f Bundled output for commit a10495d03e
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-14 00:01:04 +00:00
a10495d03e Merge pull request #3197 from flarum/as/permission-grid-fixes
Permission grid fixes
2021-12-13 18:56:11 -05:00
9e678101ca Return undefined => return null 2021-12-13 18:55:25 -05:00
e81104ce53 Bundled output for commit 3892d9b1fa
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-13 21:35:24 +00:00
f4f9f1408c Sync with v2.1 of markdown-toolbar-element 2021-12-13 16:03:34 -05:00
c8055090ca improve selected text stylization 2021-12-13 15:14:23 -05:00
d494a6a7d0 Don't throw errors for undefined relationships 2021-12-13 15:07:30 -05:00
d543ba9656 Make sure this.data.attributes is initialized.
`Object.assign` is not type-safe, and does ensure that the property being assigned to is not undefined.
2021-12-13 12:34:51 -05:00
5d8964584b Bundled output for commit ff3ea8bd0e
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-13 07:03:23 +00:00
30843fd7ef Don't lazy draw permissions dropdown
It is already lazy drawn, see 23a70affa6/js/src/admin/components/PermissionDropdown.js (L63-L63)
2021-12-13 02:00:06 -05:00
fc43191ae3 PermissionGrid fixes
Fixes https://github.com/flarum/core/issues/3169#issuecomment-979470794

- Restore wrapping `scope.render` results in a table cell tag. This was accidentially introduced in 5a26dd8c4b, and caused the issue linked above
- Rename the `SettingDropdown` attr `key` to `setting` in order to avoid naming clashes with Mithril vnode keys. `key` still works, but is deprecated.
2021-12-13 02:00:06 -05:00
ff3ea8bd0e Format 2021-12-13 01:58:47 -05:00
f51fc7b502 Fix listItems to unbrick admin extension pages
https://github.com/flarum/core/pull/3176 accidentially stopped adding a `key` attribute to wrappers of non-vnode inputs. This resulted in "all or no vnodes must have keys" errors.
2021-12-13 01:34:05 -05:00
d2a952d264 Bundled output for commit 17db36fb3c
Includes transpiled JS/TS, and Typescript declaration files (typings).

[skip ci]
2021-12-13 01:41:29 +00:00
d62c20285d Minor typefixes, fomat 2021-12-12 15:46:46 -05:00
32daeffa8a Post's discussion should always be present 2021-12-12 15:39:45 -05:00
f469bcfcd7 params arguments for id-based app.store.find should be optional 2021-12-12 15:39:28 -05:00
a8c56122fd Type-safe session instantiation 2021-12-12 15:39:06 -05:00
ed84a21f18 Rename Discussion, User files to allow jsx 2021-12-12 15:18:37 -05:00
4b5f680c39 Update js/src/common/models/User.ts
Co-authored-by: David Wheatley <hi@davwheat.dev>
2021-12-12 15:18:37 -05:00