fix: mentions posts is not an array but collection

.github/workflows/prepare-release.yml

@@ -20,7 +20,7 @@ jobs:
         uses: actions/checkout@v3
       - name: Prepare release
         uses: flarum/action-release@master
-        with:
+        env:
-          next_tag: ${{ inputs.version }}
+          NEXT_TAG: ${{ inputs.version }}
-          github_token: ${{ secrets.GITHUB_TOKEN }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          open_collective_token: ${{ secrets.OPEN_COLLECTIVE_TOKEN }}
+          OPEN_COLLECTIVE_TOKEN: ${{ secrets.OPEN_COLLECTIVE_TOKEN }}

extensions/likes/src/Api/LoadLikesRelationship.php

@@ -44,6 +44,7 @@ class LoadLikesRelationship
         $loadable = null;
 
         if ($data instanceof Discussion) {
+            // @phpstan-ignore-next-line
             $loadable = $data->newCollection($data->posts)->filter(function ($post) {
                 return $post instanceof Post;
             });

extensions/mentions/src/Api/LoadMentionedByRelationship.php

@@ -47,7 +47,8 @@ class LoadMentionedByRelationship
         $loadable = null;
 
         if ($data instanceof Discussion) {
-            $loadable = $data->newCollection($data->posts)->filter(function ($post) {
+            // @phpstan-ignore-next-line
+            $loadable = $data->newCollection((array) $data->posts)->filter(function ($post) {
                 return $post instanceof Post;
             });
         } elseif ($data instanceof Collection) {

extensions/tags/less/common/TagLabel.less

@@ -19,10 +19,6 @@
   &.colored &-text, &--colored &-text {
     color: var(--tag-color) !important;
   }
-
-  &-icon {
-    margin-right: 2px;
-  }
 }
 
 .TagLabel {

extensions/tags/src/TagRepository.php

@@ -26,7 +26,7 @@ class TagRepository
         return Tag::query();
     }
 
-    public function queryVisibleTo(?User $actor = null): Builder
+    public function queryVisibleTo(User $actor): Builder
     {
         return $this->scopeVisibleTo($this->query(), $actor);
     }
@@ -114,7 +114,7 @@ class TagRepository
      * @param User|null $user
      * @return Builder<Tag>
      */
-    protected function scopeVisibleTo(Builder $query, ?User $user = null)
+    protected function scopeVisibleTo(Builder $query, User $user = null)
     {
         if ($user !== null) {
             $query->whereVisibleTo($user);

framework/core/js/src/forum/components/DiscussionListItem.tsx

@@ -98,7 +98,7 @@ export default class DiscussionListItem<CustomAttrs extends IDiscussionListItemA
 
     return (
       <span
-        className={classList('Slidable-underneath Slidable-underneath--left Slidable-underneath--elastic', { disabled: !isUnread })}
+        className={classList('Slidable-underneath Slidable-underneath--left Slidable-underneath--elastic', { disabled: isUnread })}
         onclick={this.markAsRead.bind(this)}
       >
         {icon('fas fa-check')}

framework/core/src/Database/AbstractModel.php

@@ -256,10 +256,7 @@ abstract class AbstractModel extends Eloquent
         return $result;
     }
 
-    /**
+    public function newCollection(array $models = [])
-     * @param \Illuminate\Support\Collection|array $models
-     */
-    public function newCollection($models = [])
     {
         return new Collection($models);
     }

framework/core/src/Group/GroupRepository.php

@@ -41,7 +41,7 @@ class GroupRepository
         return $this->scopeVisibleTo($query, $actor)->firstOrFail();
     }
 
-    public function queryVisibleTo(?User $actor = null)
+    public function queryVisibleTo(User $actor = null)
     {
         return $this->scopeVisibleTo($this->query(), $actor);
     }
@@ -53,7 +53,7 @@ class GroupRepository
      * @param User|null $actor
      * @return Builder<Group>
      */
-    protected function scopeVisibleTo(Builder $query, ?User $actor = null)
+    protected function scopeVisibleTo(Builder $query, User $actor = null)
     {
         if ($actor !== null) {
             $query->whereVisibleTo($actor);

framework/core/src/Post/PostRepository.php

@@ -29,7 +29,7 @@ class PostRepository
      * @param User|null $user
      * @return Builder<Post>
      */
-    public function queryVisibleTo(?User $user = null)
+    public function queryVisibleTo(User $user = null)
     {
         $query = $this->query();