From 430dcd69d9c2238f336751d083c74046a809977c Mon Sep 17 00:00:00 2001
From: Awilum <awilum@msn.com>
Date: Sat, 7 Sep 2019 21:30:25 +0300
Subject: [PATCH] refactor(core): Forms API #186

---
 flextype/core/Forms.php | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/flextype/core/Forms.php b/flextype/core/Forms.php
index 85392eab..6ca87d20 100644
--- a/flextype/core/Forms.php
+++ b/flextype/core/Forms.php
@@ -149,17 +149,17 @@ class Forms
                             break;
                         // Template select field for selecting entry template
                         case 'template_select':
-                            $form_element = $this->templateSelectField($element_name, [], $form_value, $property);
+                            $form_element = $this->templateSelectField($element_name, $form_value, $property);
                             break;
                         // Visibility select field for selecting entry visibility state
                         case 'visibility_select':
                             $form_element = $this->visibilitySelectField($element_name, ['draft' => __('admin_entries_draft'), 'visible' => __('admin_entries_visible'), 'hidden' => __('admin_entries_hidden')], (! empty($form_value) ? $form_value : 'visible'), $property);
                             break;
                         case 'tags':
-                            $form_element = $this->tagsField($element_name, $form_value, $property);
+                            $form_element = $this->tagsField($element_name, $form_value);
                             break;
                         case 'datetimepicker':
-                            $form_element = $this->dateField($element_name, $form_value, $property);
+                            $form_element = $this->dateField($element_name, $form_value);
                             break;
                         case 'media_select':
                             $form_element = $this->mediaSelectField($element_name, $this->flextype->EntriesController->getMediaList($request->getQueryParams()['id'], false), $form_value, $property);
@@ -240,7 +240,6 @@ class Forms
      * Template select field
      *
      * @param string $name     Field name
-     * @param array  $options  Field options
      * @param string $value    Field value
      * @param array  $property Field property
      *
@@ -248,12 +247,10 @@ class Forms
      *
      * @access protected
      */
-    protected function templateSelectField(string $name, array $options, string $value, array $property) : string
+    protected function templateSelectField(string $name, string $value, array $property) : string
     {
         $_templates_list = $this->flextype['themes']->getTemplates($this->flextype['registry']->get('settings.theme'));
 
-        $options = [];
-
         if (count($_templates_list) > 0) {
             foreach ($_templates_list as $template) {
                 if ($template['type'] !== 'file' || $template['extension'] !== 'html') {
@@ -372,17 +369,14 @@ class Forms
      *
      * @param string $name     Field name
      * @param string $value    Field value
-     * @param array  $property Field property
      *
      * @return string Returns field
      *
      * @access protected
      */
-    protected function tagsField(string $name, string $value, array $property) : string
+    protected function tagsField(string $name, string $value) : string
     {
-        return '
-            <input type="text" value="' . $value . '" name="' . $name . '" class="form-control" data-role="tagsinput" />
-        ';
+        return '<input type="text" value="' . $value . '" name="' . $name . '" class="form-control" data-role="tagsinput" />';
     }
 
     /**
@@ -396,7 +390,7 @@ class Forms
      *
      * @access protected
      */
-    protected function dateField(string $name, string $value, array $property) : string
+    protected function dateField(string $name, string $value) : string
     {
         return '
             <div class="input-group date" id="datetimepicker" data-target-input="nearest">