From 66a2031497fafc2948fe015e2461d0d80eff24a0 Mon Sep 17 00:00:00 2001 From: Awilum Date: Fri, 31 Jul 2020 00:22:10 +0300 Subject: [PATCH] refactor(rest-api): initialize response_data scrutinizer-ci: $response_data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response_data = array(); before regardless. --- src/flextype/app/Endpoints/files.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/flextype/app/Endpoints/files.php b/src/flextype/app/Endpoints/files.php index c02e15b3..d2abffa9 100644 --- a/src/flextype/app/Endpoints/files.php +++ b/src/flextype/app/Endpoints/files.php @@ -157,8 +157,6 @@ $app->post('/api/files', function (Request $request, Response $response) use ($f if ($create_file) { $response_data['data'] = $flextype['media_files']->fetch($folder . '/' . basename($create_file)); - } else { - $response_data['data'] = []; } // Set response code @@ -675,10 +673,10 @@ $app->delete('/api/files/meta', function (Request $request, Response $response) // Delete file meta $delete_file_meta = $flextype['media_files_meta']->delete($path, $field); + $response_data['data'] = []; + if ($delete_file_meta) { $response_data['data'] = $flextype['media_files']->fetch($path); - } else { - $response_data['data'] = []; } // Set response code