From cce0f3de1f2d907f2f794c18a3329e91577f26ca Mon Sep 17 00:00:00 2001
From: Awilum <awilum@msn.com>
Date: Sat, 2 Feb 2019 14:33:40 +0300
Subject: [PATCH] Admin Panel: Settings Manager - code fixes and refactoring
 according to Scrutinizer Tests.

---
 site/plugins/admin/classes/SettingsManager.php | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/site/plugins/admin/classes/SettingsManager.php b/site/plugins/admin/classes/SettingsManager.php
index 634722fd..cc052c7b 100644
--- a/site/plugins/admin/classes/SettingsManager.php
+++ b/site/plugins/admin/classes/SettingsManager.php
@@ -3,7 +3,6 @@
 namespace Flextype;
 
 use Flextype\Component\Arr\Arr;
-use Flextype\Component\I18n\I18n;
 use Flextype\Component\Http\Http;
 use Flextype\Component\Filesystem\Filesystem;
 use Flextype\Component\Registry\Registry;
@@ -18,7 +17,7 @@ class SettingsManager
         Registry::set('sidebar_menu_item', 'settings');
 
         // Clear cache
-        if (Http::get('clear_cache')) {
+        if (Http::get('clear_cache') !== null && Http::get('clear_cache') == '1' && Http::get('token') !== null) {
             if (Token::check((Http::get('token')))) {
                 Cache::clear();
                 Notification::set('success', __('admin_message_cache_files_deleted'));
@@ -28,9 +27,7 @@ class SettingsManager
             }
         }
 
-        $action = Http::post('action');
-
-        if (isset($action) && $action == 'save-form') {
+        if (Http::post('action') !== null && Http::post('action') == 'save-form' && Http::post('token') !== null) {
             if (Token::check((Http::post('token')))) {
 
                 $settings = $_POST;