From dba78af69d103b6237cd1e00de3b6daab8f92ef2 Mon Sep 17 00:00:00 2001
From: Awilum <awilum@msn.com>
Date: Fri, 31 Jul 2020 00:21:10 +0300
Subject: [PATCH] refactor(rest-api): initilize response_data

scrutinizer-ci:
$response_data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response_data = array(); before regardless.
---
 src/flextype/app/Endpoints/files.php | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/flextype/app/Endpoints/files.php b/src/flextype/app/Endpoints/files.php
index 0f05b6b5..c02e15b3 100644
--- a/src/flextype/app/Endpoints/files.php
+++ b/src/flextype/app/Endpoints/files.php
@@ -153,6 +153,8 @@ $app->post('/api/files', function (Request $request, Response $response) use ($f
                 // Create file
                 $create_file = $flextype['media_files']->upload($file, $folder);
 
+                $response_data['data'] = [];
+
                 if ($create_file) {
                     $response_data['data'] = $flextype['media_files']->fetch($folder . '/' . basename($create_file));
                 } else {
@@ -243,10 +245,10 @@ $app->put('/api/files', function (Request $request, Response $response) use ($fl
                 // Rename file
                 $rename_file = $flextype['media_files']->rename($path, $new_path);
 
+                $response_data['data'] = [];
+
                 if ($rename_file) {
                     $response_data['data'] = $flextype['media_files']->fetch($new_path);
-                } else {
-                    $response_data['data'] = [];
                 }
 
                 // Set response code
@@ -332,10 +334,10 @@ $app->put('/api/files/copy', function (Request $request, Response $response) use
                 // Copy file
                 $copy_file = $flextype['media_files']->copy($path, $new_path);
 
+                $response_data['data'] = [];
+
                 if ($copy_file) {
                     $response_data['data'] = $flextype['media_files']->fetch($new_path);
-                } else {
-                    $response_data['data'] = [];
                 }
 
                 // Set response code
@@ -500,10 +502,10 @@ $app->patch('/api/files/meta', function (Request $request, Response $response) u
                 // Update file meta
                 $update_file_meta = $flextype['media_files_meta']->update($path, $field, $value);
 
+                $response_data['data'] = [];
+
                 if ($update_file_meta) {
                     $response_data['data'] = $flextype['media_files']->fetch($path);
-                } else {
-                    $response_data['data'] = [];
                 }
 
                 // Set response code
@@ -587,10 +589,10 @@ $app->post('/api/files/meta', function (Request $request, Response $response) us
                 // Add file meta
                 $add_file_meta = $flextype['media_files_meta']->add($path, $field, $value);
 
+                $response_data['data'] = [];
+
                 if ($add_file_meta) {
                     $response_data['data'] = $flextype['media_files']->fetch($path);
-                } else {
-                    $response_data['data'] = [];
                 }
 
                 // Set response code