mirror/php-h5ai
1
0
Fork 0
mirror of https://github.com/lrsjng/h5ai.git synced 2025-08-14 01:44:06 +02:00
Code Issues Releases Wiki Activity

Refactor view.

Browse Source
This commit is contained in:
Lars Jung
2015-04-30 23:01:54 +02:00
parent 3cf135b670
commit 58bf1a3091
4 changed files with 125 additions and 206 deletions
Download Patch File Download Diff File Expand all files Collapse all files

134
test/tests/unit/view/item.js
View File

@@ -1,134 +0,0 @@
(function () {
'use strict';
var ID = 'view/item';
var DEPS = ['_', '$', 'core/format', 'core/location', 'core/resource', 'core/settings'];
describe('module \'' + ID + '\'', function () {
before(function () {
this.definition = modulejs._private.definitions[ID];
this.xFormat = {
formatDate: sinon.stub().returns(util.uniqId()),
formatSize: sinon.stub().returns(util.uniqId())
};
this.xLocation = {
setLink: sinon.stub().returns(util.uniqId())
};
this.xResource = {
icon: sinon.stub().returns(util.uniqId())
};
this.xSettings = {view: {
setParentFolderLabels: false
}};
this.applyFn = function () {
this.xFormat.formatDate.reset();
this.xFormat.formatSize.reset();
this.xLocation.setLink.reset();
this.xResource.icon.reset();
return this.definition.fn(_, $, this.xFormat, this.xLocation, this.xResource, this.xSettings);
};
});
describe('definition', function () {
it('is defined', function () {
assert.isPlainObject(this.definition);
});
it('has correct id', function () {
assert.strictEqual(this.definition.id, ID);
});
it('requires correct', function () {
assert.deepEqual(this.definition.deps, DEPS);
});
it('args for each request', function () {
assert.strictEqual(this.definition.deps.length, this.definition.fn.length);
});
it('has no instance', function () {
assert.notProperty(modulejs._private.instances, ID);
});
it('inits without errors', function () {
this.applyFn();
});
});
describe('application', function () {
it('returns object with 1 property', function () {
var instance = this.applyFn();
assert.isPlainObject(instance);
assert.lengthOfKeys(instance, 1);
});
});
describe('.render()', function () {
before(function () {
this.createItem = function () {
return {
isFolder: sinon.stub().returns(false),
label: util.uniqId(),
time: 0,
size: 0,
type: util.uniqId(),
isManaged: false,
icon: null,
isCurrentParentFolder: sinon.stub().returns(false)
};
};
});
it('is function', function () {
var instance = this.applyFn();
assert.isFunction(instance.render);
});
it('returns jQuery instance of single HTML element', function () {
var item = this.createItem();
var instance = this.applyFn();
var $item = instance.render(item);
assert.isObject($item);
assert.lengthOf($item, 1);
assert.isString($item.jquery);
});
it('$item.data(\'item\') is back reference to item', function () {
var item = this.createItem();
var instance = this.applyFn();
var $item = instance.render(item);
assert.strictEqual($item.data('item'), item);
});
it('sets item.$view as reference to $item', function () {
var item = this.createItem();
var instance = this.applyFn();
var $item = instance.render(item);
assert.strictEqual(item.$view, $item);
});
});
});
}());

76
test/tests/unit/view/view.js
View File

@@ -2,7 +2,7 @@
'use strict';
var ID = 'view/view';
var DEPS = ['_', '$', 'core/event', 'core/format', 'core/settings', 'view/content', 'view/item'];
var DEPS = ['_', '$', 'core/event', 'core/format', 'core/location', 'core/resource', 'core/settings', 'view/content'];
describe('module \'' + ID + '\'', function () {
@@ -15,20 +15,32 @@ describe('module \'' + ID + '\'', function () {
pub: sinon.stub()
};
this.xFormat = {
setDefaultMetric: sinon.stub()
setDefaultMetric: sinon.stub(),
formatDate: sinon.stub().returns(util.uniqId()),
formatSize: sinon.stub().returns(util.uniqId())
};
this.xSettings = util.uniqObj();
this.xLocation = {
setLink: sinon.stub().returns(util.uniqId())
};
this.xResource = {
icon: sinon.stub().returns(util.uniqId())
};
this.xSettings = {view: {
setParentFolderLabels: false
}};
this.xContent = {$el: null};
this.xItem = {render: sinon.stub()};
this.applyFn = function () {
this.xEvent.sub.reset();
this.xEvent.pub.reset();
this.xFormat.setDefaultMetric.reset();
this.xItem.render.reset();
this.xFormat.formatDate.reset();
this.xFormat.formatSize.reset();
this.xLocation.setLink.reset();
this.xResource.icon.reset();
return this.definition.fn(_, $, this.xEvent, this.xFormat, this.xSettings, this.xContent, this.xItem);
return this.definition.fn(_, $, this.xEvent, this.xFormat, this.xLocation, this.xResource, this.xSettings, this.xContent);
};
});
@@ -147,6 +159,58 @@ describe('module \'' + ID + '\'', function () {
assert.strictEqual(instance.$items.attr('id'), 'items');
});
});
// describe('.render()', function () {
// before(function () {
// this.createItem = function () {
// return {
// isFolder: sinon.stub().returns(false),
// label: util.uniqId(),
// time: 0,
// size: 0,
// type: util.uniqId(),
// isManaged: false,
// icon: null,
// isCurrentParentFolder: sinon.stub().returns(false)
// };
// };
// });
// it('is function', function () {
// var instance = this.applyFn();
// assert.isFunction(instance.render);
// });
// it('returns jQuery instance of single HTML element', function () {
// var item = this.createItem();
// var instance = this.applyFn();
// var $item = instance.render(item);
// assert.isObject($item);
// assert.lengthOf($item, 1);
// assert.isString($item.jquery);
// });
// it('$item.data(\'item\') is back reference to item', function () {
// var item = this.createItem();
// var instance = this.applyFn();
// var $item = instance.render(item);
// assert.strictEqual($item.data('item'), item);
// });
// it('sets item.$view as reference to $item', function () {
// var item = this.createItem();
// var instance = this.applyFn();
// var $item = instance.render(item);
// assert.strictEqual(item.$view, $item);
// });
// });
});
}());