1
0
mirror of https://github.com/Seldaek/monolog.git synced 2025-10-19 23:56:17 +02:00

Codereview fixes based on @stof comments

This commit is contained in:
Anton Nizhegorodov
2016-11-13 23:02:58 +02:00
committed by Haralan Dobrev
parent 4ab8ed0a53
commit 01a2ac25a2
3 changed files with 15 additions and 32 deletions

View File

@@ -46,21 +46,10 @@ class SlackHandler extends SocketHandler
* @param bool $includeContextAndExtra Whether the attachment should include context and extra data
* @throws MissingExtensionException If no OpenSSL PHP extension configured
*/
public function __construct(
$token,
$channel,
$username = 'Monolog',
$useAttachment = true,
$iconEmoji = null,
$level = Logger::CRITICAL,
$bubble = true,
$useShortAttachment = false,
$includeContextAndExtra = false
) {
public function __construct($token, $channel, $username = 'Monolog', $useAttachment = true, $iconEmoji = null, $level = Logger::CRITICAL, $bubble = true, $useShortAttachment = false, $includeContextAndExtra = false)
{
if (!extension_loaded('openssl')) {
throw new MissingExtensionException(
'The OpenSSL PHP extension is required to use the SlackHandler'
);
throw new MissingExtensionException('The OpenSSL PHP extension is required to use the SlackHandler');
}
parent::__construct('ssl://slack.com:443', $level, $bubble);