mirror/php-monolog
1
0
Fork 0
mirror of https://github.com/Seldaek/monolog.git synced 2025-08-08 14:16:42 +02:00
Code Issues Releases Wiki Activity

Specify port in the connection string instead of adding a protected property

Browse Source
This commit is contained in:
Jordi Boggiano
2013-01-06 21:38:40 +01:00
parent c104338565
commit 09d8747914
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Monolog/Handler/PushoverHandler.php
View File

@@ -34,8 +34,7 @@ class PushoverHandler extends SocketHandler
*/ */
public function __construct($token, $user, $title = 'Monolog', $level = Logger::CRITICAL, $bubble = true) public function __construct($token, $user, $title = 'Monolog', $level = Logger::CRITICAL, $bubble = true)
{ {
parent::__construct('api.pushover.net', $level, $bubble); parent::__construct('api.pushover.net:80', $level, $bubble);
$this->connectionPort = 80;
$this->token = $token; $this->token = $token;
$this->user = $user; $this->user = $user;

7
src/Monolog/Handler/SocketHandler.php
View File

@@ -22,7 +22,6 @@ use Monolog\Logger;
class SocketHandler extends AbstractProcessingHandler class SocketHandler extends AbstractProcessingHandler
{ {
private $connectionString; private $connectionString;
protected $connectionPort = -1;
private $connectionTimeout; private $connectionTimeout;
private $resource; private $resource;
private $timeout = 0; private $timeout = 0;
@@ -172,7 +171,7 @@ class SocketHandler extends AbstractProcessingHandler
*/ */
protected function pfsockopen() protected function pfsockopen()
{ {
return @pfsockopen($this->connectionString, $this->connectionPort, $this->errno, $this->errstr, $this->connectionTimeout); return @pfsockopen($this->connectionString, -1, $this->errno, $this->errstr, $this->connectionTimeout);
} }
/** /**
@@ -180,7 +179,7 @@ class SocketHandler extends AbstractProcessingHandler
*/ */
protected function fsockopen() protected function fsockopen()
{ {
return @fsockopen($this->connectionString, $this->connectionPort, $this->errno, $this->errstr, $this->connectionTimeout); return @fsockopen($this->connectionString, -1, $this->errno, $this->errstr, $this->connectionTimeout);
} }
/** /**
@@ -259,7 +258,7 @@ class SocketHandler extends AbstractProcessingHandler
} }
} }
protected function writeToSocket($data) private function writeToSocket($data)
{ {
$length = strlen($data); $length = strlen($data);
$sent = 0; $sent = 0;