mirror/php-monolog
1
0
Fork 0
mirror of https://github.com/Seldaek/monolog.git synced 2025-08-12 08:04:02 +02:00
Code Issues Releases Wiki Activity

Use constants for Slack colors

Browse Source
This commit is contained in:
Haralan Dobrev
2016-11-14 23:06:48 +02:00
parent 0956a74897
commit 115f6710b1
2 changed files with 21 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Monolog/Handler/Slack/SlackRecord.php
View File

@@ -25,6 +25,14 @@ use Monolog\Formatter\FormatterInterface;
*/ */
class SlackRecord class SlackRecord
{ {
const COLOR_DANGER = 'danger';
const COLOR_WARNING = 'warning';
const COLOR_GOOD = 'good';
const COLOR_DEFAULT = '#e3e4e6';
/** /**
* Slack channel (encoded ID or name) * Slack channel (encoded ID or name)
* @var string * @var string
@@ -194,13 +202,13 @@ class SlackRecord
{ {
switch (true) { switch (true) {
case $level >= Logger::ERROR: case $level >= Logger::ERROR:
return 'danger'; return self::COLOR_DANGER;
case $level >= Logger::WARNING: case $level >= Logger::WARNING:
return 'warning'; return self::COLOR_WARNING;
case $level >= Logger::INFO: case $level >= Logger::INFO:
return 'good'; return self::COLOR_GOOD;
default: default:
return '#e3e4e6'; return self::COLOR_DEFAULT;
} }
} }

17
tests/Monolog/Handler/SlackHandlerTest.php
View File

@@ -14,6 +14,7 @@ namespace Monolog\Handler;
use Monolog\TestCase; use Monolog\TestCase;
use Monolog\Logger; use Monolog\Logger;
use Monolog\Formatter\LineFormatter; use Monolog\Formatter\LineFormatter;
use Monolog\Handler\Slack\SlackRecord;
/** /**
* @author Greg Kedzierski <greg@gregkedzierski.com> * @author Greg Kedzierski <greg@gregkedzierski.com>
@@ -111,14 +112,14 @@ class SlackHandlerTest extends TestCase
public function provideLevelColors() public function provideLevelColors()
{ {
return array( return array(
array(Logger::DEBUG, '%23e3e4e6'), // escaped #e3e4e6 array(Logger::DEBUG, urlencode(SlackRecord::COLOR_DEFAULT)),
array(Logger::INFO, 'good'), array(Logger::INFO, SlackRecord::COLOR_GOOD),
array(Logger::NOTICE, 'good'), array(Logger::NOTICE, SlackRecord::COLOR_GOOD),
array(Logger::WARNING, 'warning'), array(Logger::WARNING, SlackRecord::COLOR_WARNING),
array(Logger::ERROR, 'danger'), array(Logger::ERROR, SlackRecord::COLOR_DANGER),
array(Logger::CRITICAL, 'danger'), array(Logger::CRITICAL, SlackRecord::COLOR_DANGER),
array(Logger::ALERT, 'danger'), array(Logger::ALERT, SlackRecord::COLOR_DANGER),
array(Logger::EMERGENCY,'danger'), array(Logger::EMERGENCY,SlackRecord::COLOR_DANGER),
); );
} }