From 1107013b9c3952db74284a7640f1f78581b164c9 Mon Sep 17 00:00:00 2001 From: MilesChou Date: Tue, 24 Apr 2018 23:17:02 +0800 Subject: [PATCH 1/2] Open visibility for slack handlers --- src/Monolog/Handler/SlackHandler.php | 4 ++-- src/Monolog/Handler/SlackWebhookHandler.php | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Monolog/Handler/SlackHandler.php b/src/Monolog/Handler/SlackHandler.php index 3ac4d836..2c2cc4c0 100644 --- a/src/Monolog/Handler/SlackHandler.php +++ b/src/Monolog/Handler/SlackHandler.php @@ -27,13 +27,13 @@ class SlackHandler extends SocketHandler * Slack API token * @var string */ - private $token; + protected $token; /** * Instance of the SlackRecord util class preparing data for Slack API. * @var SlackRecord */ - private $slackRecord; + protected $slackRecord; /** * @param string $token Slack API token diff --git a/src/Monolog/Handler/SlackWebhookHandler.php b/src/Monolog/Handler/SlackWebhookHandler.php index 9a1bbb44..19f92cef 100644 --- a/src/Monolog/Handler/SlackWebhookHandler.php +++ b/src/Monolog/Handler/SlackWebhookHandler.php @@ -27,13 +27,13 @@ class SlackWebhookHandler extends AbstractProcessingHandler * Slack Webhook token * @var string */ - private $webhookUrl; + protected $webhookUrl; /** * Instance of the SlackRecord util class preparing data for Slack API. * @var SlackRecord */ - private $slackRecord; + protected $slackRecord; /** * @param string $webhookUrl Slack Webhook URL From 985fdb3eae0ad1085e2ccb291278d69b18d6919a Mon Sep 17 00:00:00 2001 From: MilesChou Date: Wed, 25 Apr 2018 15:51:22 +0800 Subject: [PATCH 2/2] Add getter for webhook and token property --- src/Monolog/Handler/SlackHandler.php | 9 +++++++-- src/Monolog/Handler/SlackWebhookHandler.php | 9 +++++++-- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/Monolog/Handler/SlackHandler.php b/src/Monolog/Handler/SlackHandler.php index 2c2cc4c0..45d634f4 100644 --- a/src/Monolog/Handler/SlackHandler.php +++ b/src/Monolog/Handler/SlackHandler.php @@ -27,13 +27,13 @@ class SlackHandler extends SocketHandler * Slack API token * @var string */ - protected $token; + private $token; /** * Instance of the SlackRecord util class preparing data for Slack API. * @var SlackRecord */ - protected $slackRecord; + private $slackRecord; /** * @param string $token Slack API token @@ -75,6 +75,11 @@ class SlackHandler extends SocketHandler return $this->slackRecord; } + public function getToken() + { + return $this->token; + } + /** * {@inheritdoc} * diff --git a/src/Monolog/Handler/SlackWebhookHandler.php b/src/Monolog/Handler/SlackWebhookHandler.php index 19f92cef..1ef85fae 100644 --- a/src/Monolog/Handler/SlackWebhookHandler.php +++ b/src/Monolog/Handler/SlackWebhookHandler.php @@ -27,13 +27,13 @@ class SlackWebhookHandler extends AbstractProcessingHandler * Slack Webhook token * @var string */ - protected $webhookUrl; + private $webhookUrl; /** * Instance of the SlackRecord util class preparing data for Slack API. * @var SlackRecord */ - protected $slackRecord; + private $slackRecord; /** * @param string $webhookUrl Slack Webhook URL @@ -70,6 +70,11 @@ class SlackWebhookHandler extends AbstractProcessingHandler return $this->slackRecord; } + public function getWebhookUrl() + { + return $this->webhookUrl; + } + /** * {@inheritdoc} *