mirror/php-monolog
1
0
Fork 0
mirror of https://github.com/Seldaek/monolog.git synced 2025-08-05 04:37:38 +02:00
Code Issues Releases Wiki Activity

Do not put empty Slack attachments array by default

Browse Source
This commit is contained in:
Haralan Dobrev
2016-11-19 13:39:27 +02:00
parent 8b2b13546e
commit 26b526d9fb
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/Monolog/Handler/Slack/SlackRecord.php
View File

@@ -99,7 +99,6 @@ class SlackRecord
$dataArray = array( $dataArray = array(
'username' => $this->username, 'username' => $this->username,
'text' => '', 'text' => '',
'attachments' => array(),
); );
if ($this->channel) { if ($this->channel) {

5
tests/Monolog/Handler/Slack/SlackRecordTest.php
View File

@@ -143,13 +143,12 @@ class SlackRecordTest extends TestCase
$this->assertSame('', $data['text']); $this->assertSame('', $data['text']);
} }
public function testAttachmentsEmptyIfNoAttachment() public function testAttachmentsNotPresentIfNoAttachment()
{ {
$record = new SlackRecord($this->channel, 'Monolog', false); $record = new SlackRecord($this->channel, 'Monolog', false);
$data = $record->getSlackData($this->getRecord()); $data = $record->getSlackData($this->getRecord());
$this->assertArrayHasKey('attachments', $data); $this->assertArrayNotHasKey('attachments', $data);
$this->assertSame(array(), $data['attachments']);
} }
public function testAddsOneAttachment() public function testAddsOneAttachment()