From 4814e79f3f8187824cd5332f0b67730514c041fc Mon Sep 17 00:00:00 2001 From: Jordi Boggiano Date: Thu, 6 Feb 2014 13:42:34 +0100 Subject: [PATCH] CS fixes and a BC nitpick --- src/Monolog/Handler/HipChatHandler.php | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/Monolog/Handler/HipChatHandler.php b/src/Monolog/Handler/HipChatHandler.php index 1e75343c..3f0b77b0 100644 --- a/src/Monolog/Handler/HipChatHandler.php +++ b/src/Monolog/Handler/HipChatHandler.php @@ -175,13 +175,18 @@ class HipChatHandler extends SocketHandler $batchRecords = $this->combineRecords($records); - foreach($batchRecords as $batchRecord) { - + $handled = false; + foreach ($batchRecords as $batchRecord) { if ($this->isHandling($batchRecord)) { $this->write($batchRecord); + $handled = true; } } + if (!$handled) { + return false; + } + return false === $this->bubble; } @@ -205,7 +210,6 @@ class HipChatHandler extends SocketHandler $datetime = null; foreach ($records as $record) { - $record = $this->processRecord($record); if ($record['level'] > $level) { @@ -230,7 +234,6 @@ class HipChatHandler extends SocketHandler ); if (!$this->validateStringLength($batchRecord['formatted'], static::MAXIMUM_MESSAGE_LENGTH)) { - // Pop the last message and implode the remainging messages $lastMessage = array_pop($messages); $lastFormattedMessage = array_pop($formattedMessages);