mirror/php-monolog
1
0
Fork 0
mirror of https://github.com/Seldaek/monolog.git synced 2025-08-06 13:16:39 +02:00
Code Issues Releases Wiki Activity

Merge pull request #761 from xabbuh/patch-1

Browse Source 
extract browser detection regex into a constant
This commit is contained in:
Jordi Boggiano
2016-04-10 11:56:07 +01:00
parent 064b38c167 f72b5036f8
commit 48e4f91310
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Monolog/Handler/ChromePHPHandler.php
View File

@@ -32,6 +32,11 @@ class ChromePHPHandler extends AbstractProcessingHandler
* Header name * Header name
*/ */
const HEADER_NAME = 'X-ChromeLogger-Data'; const HEADER_NAME = 'X-ChromeLogger-Data';
/**
* Regular expression to detect supported browsers (matches any Chrome, or Firefox 43+)
*/
const USER_AGENT_REGEX = '{\b(?:Chrome/\d+(?:\.\d+)*|Firefox/(?:4[3-9]|[5-9]\d|\d{3,})(?:\.\d)*)\b}';
protected static $initialized = false; protected static $initialized = false;
@@ -177,8 +182,7 @@ class ChromePHPHandler extends AbstractProcessingHandler
return false; return false;
} }
// matches any Chrome, or Firefox 43+ return preg_match(self::USER_AGENT_REGEX, $_SERVER['HTTP_USER_AGENT']);
return preg_match('{\b(?:Chrome/\d+(?:\.\d+)*|Firefox/(?:4[3-9]|[5-9]\d|\d{3,})(?:\.\d)*)\b}', $_SERVER['HTTP_USER_AGENT']);
} }
/** /**