mirror/php-monolog
1
0
Fork 0
mirror of https://github.com/Seldaek/monolog.git synced 2025-08-04 20:27:31 +02:00
Code Issues Releases Wiki Activity

Make sure extra/context variables are stringified when more than one level deep

Browse Source
This commit is contained in:
Anton Nizhegorodov
2016-11-13 22:32:40 +02:00
committed by Haralan Dobrev
parent ec75076ded
commit 4ab8ed0a53
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Monolog/Handler/Slack/SlackRecord.php
View File

@@ -96,7 +96,7 @@ class SlackRecord
$this->includeContextAndExtra = $includeContextAndExtra; $this->includeContextAndExtra = $includeContextAndExtra;
$this->formatter = $formatter; $this->formatter = $formatter;
if ($this->includeContextAndExtra && $this->useShortAttachment) { if ($this->includeContextAndExtra) {
$this->lineFormatter = new LineFormatter(); $this->lineFormatter = new LineFormatter();
} }
} }
@@ -152,7 +152,7 @@ class SlackRecord
foreach ($record['extra'] as $var => $val) { foreach ($record['extra'] as $var => $val) {
$attachment['fields'][] = array( $attachment['fields'][] = array(
'title' => $var, 'title' => $var,
'value' => $val, 'value' => is_array($val) ? $this->lineFormatter->stringify($val) : $val,
'short' => $this->useShortAttachment, 'short' => $this->useShortAttachment,
); );
} }
@@ -171,7 +171,7 @@ class SlackRecord
foreach ($record['context'] as $var => $val) { foreach ($record['context'] as $var => $val) {
$attachment['fields'][] = array( $attachment['fields'][] = array(
'title' => $var, 'title' => $var,
'value' => $val, 'value' => is_array($val) ? $this->lineFormatter->stringify($val) : $val,
'short' => $this->useShortAttachment, 'short' => $this->useShortAttachment,
); );
} }

2
tests/Monolog/Handler/Slack/SlackRecordTest.php
View File

@@ -308,7 +308,7 @@ class SlackRecordTest extends TestCase
), ),
array( array(
'title' => 'tags', 'title' => 'tags',
'value' => array('web'), 'value' => '["web"]',
'short' => false 'short' => false
), ),
array( array(