mirror/php-monolog
1
0
Fork 0
mirror of https://github.com/Seldaek/monolog.git synced 2025-08-06 13:16:39 +02:00
Code Issues Releases Wiki Activity

Fix Buffer, Group and FingersCrossed handlers to make use of their processors, fixes #170

Browse Source
This commit is contained in:
Jordi Boggiano
2013-03-17 19:36:02 +01:00
parent eaf2b07120
commit 5feb21ae1a
6 changed files with 73 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Monolog/Handler/BufferHandler.php
View File

@@ -65,6 +65,12 @@ class BufferHandler extends AbstractHandler
}
}
if ($this->processors) {
foreach ($this->processors as $processor) {
$record = call_user_func($processor, $record);
}
}
$this->buffer[] = $record;
$this->bufferSize++;

6
src/Monolog/Handler/FingersCrossedHandler.php
View File

@@ -69,6 +69,12 @@ class FingersCrossedHandler extends AbstractHandler
*/
public function handle(array $record)
{
if ($this->processors) {
foreach ($this->processors as $processor) {
$record = call_user_func($processor, $record);
}
}
if ($this->buffering) {
$this->buffer[] = $record;
if ($this->bufferSize > 0 && count($this->buffer) > $this->bufferSize) {

6
src/Monolog/Handler/GroupHandler.php
View File

@@ -55,6 +55,12 @@ class GroupHandler extends AbstractHandler
*/
public function handle(array $record)
{
if ($this->processors) {
foreach ($this->processors as $processor) {
$record = call_user_func($processor, $record);
}
}
foreach ($this->handlers as $handler) {
$handler->handle($record);
}

19
tests/Monolog/Handler/BufferHandlerTest.php
View File

@@ -127,4 +127,23 @@ class BufferHandlerTest extends TestCase
$this->assertTrue($test->hasDebugRecords());
$this->assertFalse($test->hasWarningRecords());
}
/**
* @covers Monolog\Handler\BufferHandler::handle
*/
public function testHandleUsesProcessors()
{
$test = new TestHandler();
$handler = new BufferHandler($test);
$handler->pushProcessor(function ($record) {
$record['extra']['foo'] = true;
return $record;
});
$handler->handle($this->getRecord(Logger::WARNING));
$handler->flush();
$this->assertTrue($test->hasWarningRecords());
$records = $test->getRecords();
$this->assertTrue($records[0]['extra']['foo']);
}
}

18
tests/Monolog/Handler/FingersCrossedHandlerTest.php
View File

@@ -148,4 +148,22 @@ class FingersCrossedHandlerTest extends TestCase
$this->assertTrue($test->hasDebugRecords());
$this->assertTrue($test->hasWarningRecords());
}
/**
* @covers Monolog\Handler\FingersCrossedHandler::handle
*/
public function testHandleUsesProcessors()
{
$test = new TestHandler();
$handler = new FingersCrossedHandler($test, Logger::INFO);
$handler->pushProcessor(function ($record) {
$record['extra']['foo'] = true;
return $record;
});
$handler->handle($this->getRecord(Logger::WARNING));
$this->assertTrue($test->hasWarningRecords());
$records = $test->getRecords();
$this->assertTrue($records[0]['extra']['foo']);
}
}

18
tests/Monolog/Handler/GroupHandlerTest.php
View File

@@ -68,4 +68,22 @@ class GroupHandlerTest extends TestCase
$this->assertTrue($handler->isHandling($this->getRecord(Logger::WARNING)));
$this->assertFalse($handler->isHandling($this->getRecord(Logger::DEBUG)));
}
/**
* @covers Monolog\Handler\GroupHandler::handle
*/
public function testHandleUsesProcessors()
{
$test = new TestHandler();
$handler = new GroupHandler(array($test));
$handler->pushProcessor(function ($record) {
$record['extra']['foo'] = true;
return $record;
});
$handler->handle($this->getRecord(Logger::WARNING));
$this->assertTrue($test->hasWarningRecords());
$records = $test->getRecords();
$this->assertTrue($records[0]['extra']['foo']);
}
}