diff --git a/src/Monolog/Handler/StreamHandler.php b/src/Monolog/Handler/StreamHandler.php index 5c8fc1fc..8f31dcd2 100644 --- a/src/Monolog/Handler/StreamHandler.php +++ b/src/Monolog/Handler/StreamHandler.php @@ -26,14 +26,16 @@ class StreamHandler extends AbstractProcessingHandler protected $url; private $errorMessage; protected $filePermission; + protected $preferLocking; /** * @param string $stream * @param integer $level The minimum logging level at which this handler will be triggered * @param Boolean $bubble Whether the messages that are handled can bubble up the stack or not * @param int $filePermissions Optional file permissions (default (0644) are only for owner read/write) + * @param Boolean $preferLocking Try to lock log file before doing any writes */ - public function __construct($stream, $level = Logger::DEBUG, $bubble = true, $filePermission = null) + public function __construct($stream, $level = Logger::DEBUG, $bubble = true, $filePermission = null, $preferLocking = false) { parent::__construct($level, $bubble); if (is_resource($stream)) { @@ -43,6 +45,7 @@ class StreamHandler extends AbstractProcessingHandler } $this->filePermission = $filePermission; + $this->preferLocking = $preferLocking; } /** @@ -77,7 +80,17 @@ class StreamHandler extends AbstractProcessingHandler throw new \UnexpectedValueException(sprintf('The stream or file "%s" could not be opened: '.$this->errorMessage, $this->url)); } } + + if ($this->preferLocking) { + // ignoring errors here, there's not much we can do about them + flock($this->stream, LOCK_EX); + } + fwrite($this->stream, (string) $record['formatted']); + + if ($this->preferLocking) { + flock($this->stream, LOCK_UN); + } } private function customErrorHandler($code, $msg) diff --git a/tests/Monolog/Handler/StreamHandlerTest.php b/tests/Monolog/Handler/StreamHandlerTest.php index 63d4fef6..e9b9c38f 100644 --- a/tests/Monolog/Handler/StreamHandlerTest.php +++ b/tests/Monolog/Handler/StreamHandlerTest.php @@ -53,6 +53,17 @@ class StreamHandlerTest extends TestCase $handler->handle($this->getRecord()); } + /** + * @covers Monolog\Handler\StreamHandler::__construct + * @covers Monolog\Handler\StreamHandler::write + */ + public function testWriteLocking() + { + $temp = sys_get_temp_dir() . DIRECTORY_SEPARATOR . 'monolog_locked_log'; + $handler = new StreamHandler($temp, Logger::DEBUG, true, null, true); + $handler->handle($this->getRecord()); + } + /** * @expectedException LogicException * @covers Monolog\Handler\StreamHandler::__construct