mirror/php-monolog
1
0
Fork 0
mirror of https://github.com/Seldaek/monolog.git synced 2025-08-01 19:00:20 +02:00
Code Issues Releases Wiki Activity

Expect and document a more concrete exception type

Browse Source 
As was proposed during review.
This commit is contained in:
Thomas Praxl
2019-11-25 12:01:34 +01:00
parent 3dcb1919a3
commit 764601c606
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Monolog/Handler/StreamHandler.php
View File

@@ -32,7 +32,7 @@ class StreamHandler extends AbstractProcessingHandler
private $dirCreated; private $dirCreated;
/** /**
* @param resource|string $stream If a missing path can't be created, an Exception will be thrown on first write * @param resource|string $stream If a missing path can't be created, an UnexpectedValueException will be thrown on first write
* @param string|int $level The minimum logging level at which this handler will be triggered * @param string|int $level The minimum logging level at which this handler will be triggered
* @param bool $bubble Whether the messages that are handled can bubble up the stack or not * @param bool $bubble Whether the messages that are handled can bubble up the stack or not
* @param int|null $filePermission Optional file permissions (default (0644) are only for owner read/write) * @param int|null $filePermission Optional file permissions (default (0644) are only for owner read/write)

2
tests/Monolog/Handler/StreamHandlerTest.php
View File

@@ -203,7 +203,7 @@ class StreamHandlerTest extends TestCase
); );
} }
$this->expectException(\Exception::class); $this->expectException(\UnexpectedValueException::class);
$this->expectExceptionMessage('There is no existing directory at'); $this->expectExceptionMessage('There is no existing directory at');
$handler->handle($this->getRecord()); $handler->handle($this->getRecord());