From 812d63b1719237779a87f47b9aa24fb59f3abec3 Mon Sep 17 00:00:00 2001 From: Victor Pryazhnikov Date: Sun, 18 Apr 2021 21:33:01 +0300 Subject: [PATCH] Fix of incorrect DynamoDB mock creation addMethods([]) breaks the methods configured at onlyMethods() call --- tests/Monolog/Handler/DynamoDbHandlerTest.php | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/Monolog/Handler/DynamoDbHandlerTest.php b/tests/Monolog/Handler/DynamoDbHandlerTest.php index bd11abf4..2b237bfa 100644 --- a/tests/Monolog/Handler/DynamoDbHandlerTest.php +++ b/tests/Monolog/Handler/DynamoDbHandlerTest.php @@ -35,11 +35,14 @@ class DynamoDbHandlerTest extends TestCase $absentMethods[] = 'formatAttributes'; } - $this->client = $this->getMockBuilder('Aws\DynamoDb\DynamoDbClient') + $clientMockBuilder = $this->getMockBuilder('Aws\DynamoDb\DynamoDbClient') ->onlyMethods($implementedMethods) - ->addMethods($absentMethods) - ->disableOriginalConstructor() - ->getMock(); + ->disableOriginalConstructor(); + if ($absentMethods) { + $clientMockBuilder->addMethods($absentMethods); + } + + $this->client = $clientMockBuilder->getMock(); } public function testConstruct()