extracted activation logic from FingersCrossedHandler

src/Monolog/Handler/FingersCrossed/ActivationStrategyInterface.php

@@ -0,0 +1,28 @@
+<?php
+
+/*
+ * This file is part of the Monolog package.
+ *
+ * (c) Jordi Boggiano <j.boggiano@seld.be>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Monolog\Handler\FingersCrossed;
+
+/**
+ * Interface for activation strategies for the FingersCrossedHandler.
+ *
+ * @author Johannes M. Schmitt <schmittjoh@gmail.com>
+ */
+interface ActivationStrategyInterface
+{
+    /**
+     * Returns whether the given record activates the handler.
+     *
+     * @param array $record
+     * @return Boolean
+     */
+    function isHandlerActivated(array $record);
+}

src/Monolog/Handler/FingersCrossed/ErrorLevelActivationStrategy.php

@@ -0,0 +1,32 @@
+<?php
+
+/*
+ * This file is part of the Monolog package.
+ *
+ * (c) Jordi Boggiano <j.boggiano@seld.be>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Monolog\Handler\FingersCrossed;
+
+/**
+ * Error level based activation strategy.
+ *
+ * @author Johannes M. Schmitt <schmittjoh@gmail.com>
+ */
+class ErrorLevelActivationStrategy implements ActivationStrategyInterface
+{
+    private $actionLevel;
+
+    public function __construct($actionLevel)
+    {
+        $this->actionLevel = $actionLevel;
+    }
+
+    public function isHandlerActivated(array $record)
+    {
+        return $record['level'] >= $this->actionLevel;
+    }
+}

src/Monolog/Handler/FingersCrossedHandler.php

@@ -11,6 +11,10 @@
 
 namespace Monolog\Handler;
 
+use Monolog\Handler\FingersCrossed\ErrorLevelActivationStrategy;
+
+use Monolog\Handler\FingersCrossed\ActivationStrategyInterface;
+
 use Monolog\Logger;
 
 /**
@@ -25,7 +29,7 @@ use Monolog\Logger;
 class FingersCrossedHandler extends AbstractHandler
 {
     protected $handler;
-    protected $actionLevel;
+    protected $activationStrategy;
     protected $buffering = true;
     protected $bufferSize;
     protected $buffer = array();
@@ -33,15 +37,15 @@ class FingersCrossedHandler extends AbstractHandler
 
     /**
      * @param callback|HandlerInterface $handler Handler or factory callback($record, $fingersCrossedHandler).
-     * @param int $actionLevel The minimum logging level at which this handler will be triggered
+     * @param ActivationStrategyInterface $activationStrategy Strategy which determines when this handler takes action
      * @param int $bufferSize How many entries should be buffered at most, beyond that the oldest items are removed from the buffer.
      * @param Boolean $bubble Whether the messages that are handled can bubble up the stack or not
      * @param Boolean $stopBuffering Whether the handler should stop buffering after being triggered (default true)
      */
-    public function __construct($handler, $actionLevel = Logger::WARNING, $bufferSize = 0, $bubble = true, $stopBuffering = true)
+    public function __construct($handler, ActivationStrategyInterface $activationStrategy = null, $bufferSize = 0, $bubble = true, $stopBuffering = true)
     {
         $this->handler = $handler;
-        $this->actionLevel = $actionLevel;
+        $this->activationStrategy = $activationStrategy ?: new ErrorLevelActivationStrategy(Logger::WARNING);
         $this->bufferSize = $bufferSize;
         $this->bubble = $bubble;
         $this->stopBuffering = $stopBuffering;
@@ -65,7 +69,7 @@ class FingersCrossedHandler extends AbstractHandler
             if ($this->bufferSize > 0 && count($this->buffer) > $this->bufferSize) {
                 array_shift($this->buffer);
             }
-            if ($record['level'] >= $this->actionLevel) {
+            if ($this->activationStrategy->isHandlerActivated($record)) {
                 if ($this->stopBuffering) {
                     $this->buffering = false;
                 }

tests/Monolog/Handler/FingersCrossedHandlerTest.php

@@ -11,6 +11,8 @@
 
 namespace Monolog\Handler;
 
+use Monolog\Handler\FingersCrossed\ErrorLevelActivationStrategy;
+
 use Monolog\TestCase;
 use Monolog\Logger;
 
@@ -69,7 +71,7 @@ class FingersCrossedHandlerTest extends TestCase
     public function testHandleRestartBufferingAfterBeingTriggeredWhenStopBufferingIsDisabled()
     {
         $test = new TestHandler();
-        $handler = new FingersCrossedHandler($test, Logger::WARNING, 0, false, false);
+        $handler = new FingersCrossedHandler($test, new ErrorLevelActivationStrategy(Logger::WARNING), 0, false, false);
         $handler->handle($this->getRecord(Logger::DEBUG));
         $handler->handle($this->getRecord(Logger::WARNING));
         $handler->handle($this->getRecord(Logger::INFO));
@@ -84,7 +86,7 @@ class FingersCrossedHandlerTest extends TestCase
     public function testHandleBufferLimit()
     {
         $test = new TestHandler();
-        $handler = new FingersCrossedHandler($test, Logger::WARNING, 2);
+        $handler = new FingersCrossedHandler($test, new ErrorLevelActivationStrategy(Logger::WARNING), 2);
         $handler->handle($this->getRecord(Logger::DEBUG));
         $handler->handle($this->getRecord(Logger::DEBUG));
         $handler->handle($this->getRecord(Logger::INFO));
@@ -130,7 +132,7 @@ class FingersCrossedHandlerTest extends TestCase
     public function testIsHandlingAlways()
     {
         $test = new TestHandler();
-        $handler = new FingersCrossedHandler($test, Logger::ERROR);
+        $handler = new FingersCrossedHandler($test, new ErrorLevelActivationStrategy(Logger::ERROR));
         $this->assertTrue($handler->isHandling($this->getRecord(Logger::DEBUG)));
     }
 }