1
0
mirror of https://github.com/Seldaek/monolog.git synced 2025-08-10 23:24:02 +02:00

Fix infinite loops when a log handler triggers logging itself

This commit is contained in:
Jordi Boggiano
2022-05-10 11:10:07 +02:00
parent 5d43fd52d3
commit a5d65f6ec4
2 changed files with 104 additions and 31 deletions

View File

@@ -11,6 +11,7 @@
namespace Monolog;
use Monolog\Handler\HandlerInterface;
use Monolog\Processor\WebProcessor;
use Monolog\Handler\TestHandler;
@@ -84,6 +85,28 @@ class LoggerTest extends \PHPUnit\Framework\TestCase
$this->assertEquals('foo', $record['channel']);
}
/**
* @covers Monolog\Logger::addRecord
*/
public function testLogPreventsCircularLogging()
{
$logger = new Logger(__METHOD__);
$loggingHandler = new LoggingHandler($logger);
$testHandler = new TestHandler();
$logger->pushHandler($loggingHandler);
$logger->pushHandler($testHandler);
$logger->addRecord(Logger::ALERT, 'test');
$records = $testHandler->getRecords();
$this->assertCount(3, $records);
$this->assertSame('ALERT', $records[0]['level_name']);
$this->assertSame('DEBUG', $records[1]['level_name']);
$this->assertSame('WARNING', $records[2]['level_name']);
}
/**
* @covers Monolog\Logger::addRecord
*/
@@ -717,3 +740,36 @@ class LoggerTest extends \PHPUnit\Framework\TestCase
$this->assertNotSame($uid2, $processorUid2->getUid());
}
}
class LoggingHandler implements HandlerInterface
{
/**
* @var Logger
*/
private $logger;
public function __construct(Logger $logger)
{
$this->logger = $logger;
}
public function isHandling(array $record): bool
{
return true;
}
public function handle(array $record): bool
{
$this->logger->debug('Log triggered while logging');
return false;
}
public function handleBatch(array $records): void
{
}
public function close(): void
{
}
}