mirror/php-monolog
1
0
Fork 0
mirror of https://github.com/Seldaek/monolog.git synced 2025-08-02 19:27:37 +02:00
Code Issues Releases Wiki Activity

Truncate single messages if they go over the hipchat limit, fixes #629

Browse Source
This commit is contained in:
Jordi Boggiano
2016-04-10 12:31:24 +01:00
parent 6c21baf553
commit ccdc8b530c
2 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Monolog/Handler/HipChatHandler.php
View File

@@ -143,6 +143,14 @@ class HipChatHandler extends SocketHandler
'color' => $this->getAlertColor($record['level']), 'color' => $this->getAlertColor($record['level']),
); );
if (!$this->validateStringLength($dataArray['message'], static::MAXIMUM_MESSAGE_LENGTH)) {
if (function_exists('mb_substr')) {
$dataArray['message'] = mb_substr($dataArray['message'], 0, static::MAXIMUM_MESSAGE_LENGTH).' [truncated]';
} else {
$dataArray['message'] = substr($dataArray['message'], 0, static::MAXIMUM_MESSAGE_LENGTH).' [truncated]';
}
}
// if we are using the legacy API then we need to send some additional information // if we are using the legacy API then we need to send some additional information
if ($this->version == self::API_V1) { if ($this->version == self::API_V1) {
$dataArray['room_id'] = $this->room; $dataArray['room_id'] = $this->room;

10
tests/Monolog/Handler/HipChatHandlerTest.php
View File

@@ -150,6 +150,16 @@ class HipChatHandlerTest extends TestCase
$this->assertRegexp('/message=Backup\+of\+database\+%22example%22\+finished\+in\+16\+minutes\./', $content); $this->assertRegexp('/message=Backup\+of\+database\+%22example%22\+finished\+in\+16\+minutes\./', $content);
} }
public function testWriteTruncatesLongMessage()
{
$this->createHandler();
$this->handler->handle($this->getRecord(Logger::CRITICAL, str_repeat('abcde', 2000)));
fseek($this->res, 0);
$content = fread($this->res, 12000);
$this->assertRegexp('/message='.str_repeat('abcde', 1900).'\+%5Btruncated%5D/', $content);
}
/** /**
* @dataProvider provideLevelColors * @dataProvider provideLevelColors
*/ */