From d809f576bb2b307320a957dd5d11fd112a0e6d48 Mon Sep 17 00:00:00 2001 From: Jordi Boggiano Date: Mon, 9 Mar 2015 09:51:58 +0000 Subject: [PATCH] Revert "Switch HipChatHandler to API v2", fixes #525 This reverts commit 01549ec4d05e2d3f33227531d9fc9454d5ef6049. --- src/Monolog/Handler/HipChatHandler.php | 3 ++- tests/Monolog/Handler/HipChatHandlerTest.php | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Monolog/Handler/HipChatHandler.php b/src/Monolog/Handler/HipChatHandler.php index 0e05a6f9..185e86e0 100644 --- a/src/Monolog/Handler/HipChatHandler.php +++ b/src/Monolog/Handler/HipChatHandler.php @@ -118,6 +118,7 @@ class HipChatHandler extends SocketHandler { $dataArray = array( 'from' => $this->name, + 'room_id' => $this->room, 'notify' => $this->notify, 'message' => $record['formatted'], 'message_format' => $this->format, @@ -135,7 +136,7 @@ class HipChatHandler extends SocketHandler */ private function buildHeader($content) { - $header = "POST /v2/room/".$this->room."/notification?auth_token=".$this->token." HTTP/1.1\r\n"; + $header = "POST /v1/rooms/message?format=json&auth_token=".$this->token." HTTP/1.1\r\n"; $header .= "Host: {$this->host}\r\n"; $header .= "Content-Type: application/x-www-form-urlencoded\r\n"; $header .= "Content-Length: " . strlen($content) . "\r\n"; diff --git a/tests/Monolog/Handler/HipChatHandlerTest.php b/tests/Monolog/Handler/HipChatHandlerTest.php index d5bedbf1..49f1dfbd 100644 --- a/tests/Monolog/Handler/HipChatHandlerTest.php +++ b/tests/Monolog/Handler/HipChatHandlerTest.php @@ -30,7 +30,7 @@ class HipChatHandlerTest extends TestCase fseek($this->res, 0); $content = fread($this->res, 1024); - $this->assertRegexp('/POST \/v2\/room\/room1\/notification\?auth_token=.* HTTP\/1.1\\r\\nHost: api.hipchat.com\\r\\nContent-Type: application\/x-www-form-urlencoded\\r\\nContent-Length: \d{2,4}\\r\\n\\r\\n/', $content); + $this->assertRegexp('/POST \/v1\/rooms\/message\?format=json&auth_token=.* HTTP\/1.1\\r\\nHost: api.hipchat.com\\r\\nContent-Type: application\/x-www-form-urlencoded\\r\\nContent-Length: \d{2,4}\\r\\n\\r\\n/', $content); return $content; } @@ -42,7 +42,7 @@ class HipChatHandlerTest extends TestCase fseek($this->res, 0); $content = fread($this->res, 1024); - $this->assertRegexp('/POST \/v2\/room\/room1\/notification\?auth_token=.* HTTP\/1.1\\r\\nHost: hipchat.foo.bar\\r\\nContent-Type: application\/x-www-form-urlencoded\\r\\nContent-Length: \d{2,4}\\r\\n\\r\\n/', $content); + $this->assertRegexp('/POST \/v1\/rooms\/message\?format=json&auth_token=.* HTTP\/1.1\\r\\nHost: hipchat.foo.bar\\r\\nContent-Type: application\/x-www-form-urlencoded\\r\\nContent-Length: \d{2,4}\\r\\n\\r\\n/', $content); return $content; } @@ -52,7 +52,7 @@ class HipChatHandlerTest extends TestCase */ public function testWriteContent($content) { - $this->assertRegexp('/from=Monolog¬ify=0&message=test1&message_format=text&color=red$/', $content); + $this->assertRegexp('/from=Monolog&room_id=room1¬ify=0&message=test1&message_format=text&color=red$/', $content); } public function testWriteWithComplexMessage()