From 021e5a5fe849b9d8cdff4c1d699e4445792a59ff Mon Sep 17 00:00:00 2001 From: Malachi Soord Date: Tue, 13 Aug 2019 16:54:43 +0200 Subject: [PATCH] Change the assert for counting test result values --- tests/Monolog/Handler/BufferHandlerTest.php | 2 +- tests/Monolog/Handler/FingersCrossedHandlerTest.php | 4 ++-- tests/Monolog/Handler/GroupHandlerTest.php | 6 +++--- tests/Monolog/Handler/WhatFailureGroupHandlerTest.php | 6 +++--- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/Monolog/Handler/BufferHandlerTest.php b/tests/Monolog/Handler/BufferHandlerTest.php index f1338b40..4867d182 100644 --- a/tests/Monolog/Handler/BufferHandlerTest.php +++ b/tests/Monolog/Handler/BufferHandlerTest.php @@ -33,7 +33,7 @@ class BufferHandlerTest extends TestCase $this->assertFalse($test->hasInfoRecords()); $handler->close(); $this->assertTrue($test->hasInfoRecords()); - $this->assertTrue(count($test->getRecords()) === 2); + $this->assertCount(2, $test->getRecords()); } /** diff --git a/tests/Monolog/Handler/FingersCrossedHandlerTest.php b/tests/Monolog/Handler/FingersCrossedHandlerTest.php index b545489c..8ecbff80 100644 --- a/tests/Monolog/Handler/FingersCrossedHandlerTest.php +++ b/tests/Monolog/Handler/FingersCrossedHandlerTest.php @@ -35,7 +35,7 @@ class FingersCrossedHandlerTest extends TestCase $handler->handle($this->getRecord(Logger::WARNING)); $handler->close(); $this->assertTrue($test->hasInfoRecords()); - $this->assertTrue(count($test->getRecords()) === 3); + $this->assertCount(3, $test->getRecords()); } /** @@ -123,7 +123,7 @@ class FingersCrossedHandlerTest extends TestCase $this->assertFalse($test->hasInfoRecords()); $handler->handle($this->getRecord(Logger::WARNING)); $this->assertTrue($test->hasInfoRecords()); - $this->assertTrue(count($test->getRecords()) === 3); + $this->assertCount(3, $test->getRecords()); } /** diff --git a/tests/Monolog/Handler/GroupHandlerTest.php b/tests/Monolog/Handler/GroupHandlerTest.php index 003c7014..b2a2713c 100644 --- a/tests/Monolog/Handler/GroupHandlerTest.php +++ b/tests/Monolog/Handler/GroupHandlerTest.php @@ -38,7 +38,7 @@ class GroupHandlerTest extends TestCase foreach ($testHandlers as $test) { $this->assertTrue($test->hasDebugRecords()); $this->assertTrue($test->hasInfoRecords()); - $this->assertTrue(count($test->getRecords()) === 2); + $this->assertCount(2, $test->getRecords()); } } @@ -53,7 +53,7 @@ class GroupHandlerTest extends TestCase foreach ($testHandlers as $test) { $this->assertTrue($test->hasDebugRecords()); $this->assertTrue($test->hasInfoRecords()); - $this->assertTrue(count($test->getRecords()) === 2); + $this->assertCount(2, $test->getRecords()); } } @@ -108,7 +108,7 @@ class GroupHandlerTest extends TestCase foreach ($testHandlers as $test) { $this->assertTrue($test->hasDebugRecords()); $this->assertTrue($test->hasInfoRecords()); - $this->assertTrue(count($test->getRecords()) === 2); + $this->assertCount(2, $test->getRecords()); $records = $test->getRecords(); $this->assertTrue($records[0]['extra']['foo']); $this->assertTrue($records[1]['extra']['foo']); diff --git a/tests/Monolog/Handler/WhatFailureGroupHandlerTest.php b/tests/Monolog/Handler/WhatFailureGroupHandlerTest.php index 6aacdde5..185351fd 100644 --- a/tests/Monolog/Handler/WhatFailureGroupHandlerTest.php +++ b/tests/Monolog/Handler/WhatFailureGroupHandlerTest.php @@ -38,7 +38,7 @@ class WhatFailureGroupHandlerTest extends TestCase foreach ($testHandlers as $test) { $this->assertTrue($test->hasDebugRecords()); $this->assertTrue($test->hasInfoRecords()); - $this->assertTrue(count($test->getRecords()) === 2); + $this->assertCount(2, $test->getRecords()); } } @@ -53,7 +53,7 @@ class WhatFailureGroupHandlerTest extends TestCase foreach ($testHandlers as $test) { $this->assertTrue($test->hasDebugRecords()); $this->assertTrue($test->hasInfoRecords()); - $this->assertTrue(count($test->getRecords()) === 2); + $this->assertCount(2, $test->getRecords()); } } @@ -108,7 +108,7 @@ class WhatFailureGroupHandlerTest extends TestCase foreach ($testHandlers as $test) { $this->assertTrue($test->hasDebugRecords()); $this->assertTrue($test->hasInfoRecords()); - $this->assertTrue(count($test->getRecords()) === 2); + $this->assertCount(2, $test->getRecords()); $records = $test->getRecords(); $this->assertTrue($records[0]['extra']['foo']); $this->assertTrue($records[1]['extra']['foo']);