mirror/php-monolog
1
0
Fork 0
mirror of https://github.com/Seldaek/monolog.git synced 2025-08-12 08:04:02 +02:00
Code Issues Releases Wiki Activity

Remove assertInternalType that it is deprecated

Browse Source
This commit is contained in:
George Mponos
2018-12-16 23:46:26 +02:00
parent 3fbaff7a63
commit ee350961da
10 changed files with 16 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/Monolog/Handler/NativeMailerHandlerTest.php
View File

@@ -87,7 +87,7 @@ class NativeMailerHandlerTest extends TestCase
// non-empty batch
$mailer->handle($this->getRecord(Logger::ERROR, "Foo\nBar\r\n\r\nBaz"));
$this->assertNotEmpty($GLOBALS['mail']);
$this->assertInternalType('array', $GLOBALS['mail']);
$this->assertIsArray($GLOBALS['mail']);
$this->assertArrayHasKey('0', $GLOBALS['mail']);
$params = $GLOBALS['mail'][0];
$this->assertCount(5, $params);
@@ -103,7 +103,7 @@ class NativeMailerHandlerTest extends TestCase
$mailer = new NativeMailerHandler('to@example.org', 'Alert: %level_name% %message%', 'from@example.org');
$mailer->handle($this->getRecord(Logger::ERROR, "Foo\nBar\r\n\r\nBaz"));
$this->assertNotEmpty($GLOBALS['mail']);
$this->assertInternalType('array', $GLOBALS['mail']);
$this->assertIsArray($GLOBALS['mail']);
$this->assertArrayHasKey('0', $GLOBALS['mail']);
$params = $GLOBALS['mail'][0];
$this->assertCount(5, $params);

2
tests/Monolog/Handler/RavenHandlerTest.php
View File

@@ -138,7 +138,7 @@ class RavenHandlerTest extends TestCase
// check to see if its reset
$handler->handle($recordWithNoContext);
$this->assertInternalType('array', $ravenClient->context->user);
$this->assertIsArray($ravenClient->context->user);
$this->assertSame('test_user_id', $ravenClient->context->user['id']);
// handle with null context

4
tests/Monolog/Handler/Slack/SlackRecordTest.php
View File

@@ -157,7 +157,7 @@ class SlackRecordTest extends TestCase
$this->assertArrayHasKey('attachments', $data);
$this->assertArrayHasKey(0, $data['attachments']);
$this->assertInternalType('array', $data['attachments'][0]);
$this->assertIsArray($data['attachments'][0]);
}
public function testTextEqualsMessageIfNoAttachment()
@@ -362,7 +362,7 @@ class SlackRecordTest extends TestCase
$record = $this->getRecord(Logger::CRITICAL, 'This is a critical message.', array('exception' => new \Exception()));
$slackRecord = new SlackRecord(null, null, true, null, false, true);
$data = $slackRecord->getSlackData($record);
$this->assertInternalType('string', $data['attachments'][0]['fields'][1]['value']);
$this->assertIsString($data['attachments'][0]['fields'][1]['value']);
}
public function testExcludeExtraAndContextFields()

5
tests/Monolog/Handler/SocketHandlerTest.php
View File

@@ -13,6 +13,7 @@ namespace Monolog\Handler;
use Monolog\Test\TestCase;
use Monolog\Logger;
use PHPUnit\Framework\MockObject\MockObject;
/**
* @author Pablo de Leon Belloc <pablolb@gmail.com>
@@ -20,7 +21,7 @@ use Monolog\Logger;
class SocketHandlerTest extends TestCase
{
/**
* @var Monolog\Handler\SocketHandler
* @var \Monolog\Handler\SocketHandler|MockObject
*/
private $handler;
@@ -247,7 +248,7 @@ class SocketHandlerTest extends TestCase
{
$this->setMockHandler();
$this->writeRecord('Hello world');
$this->assertInternalType('resource', $this->res);
$this->assertIsResource($this->res);
$this->handler->close();
$this->assertFalse(is_resource($this->res), "Expected resource to be closed after closing handler");
}