mirror/php-monolog
1
0
Fork 0
mirror of https://github.com/Seldaek/monolog.git synced 2025-08-04 12:17:35 +02:00
Code Issues Releases Wiki Activity

Make 5.3 compliant and faster call to wrapped logger, refs #437

Browse Source
This commit is contained in:
Jordi Boggiano
2014-10-21 10:21:47 +01:00
parent 77febae7de
commit f835cd21e4
2 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Monolog/Handler/PsrHandler.php
View File

@@ -49,8 +49,7 @@ class PsrHandler extends AbstractHandler
return false; return false;
} }
$logMethodName = strtolower($record['level_name']); $this->logger->log(strtolower($record['level_name']), $record['message'], $record['context']);
call_user_func([$this->logger, $logMethodName], $record['message'], $record['context']);
return false === $this->bubble; return false === $this->bubble;
} }

16
tests/Monolog/Handler/PsrHandlerTest.php
View File

@@ -21,11 +21,11 @@ class PsrHandlerTest extends TestCase
{ {
public function logLevelProvider() public function logLevelProvider()
{ {
$levels = []; $levels = array();
$monologLogger = new Logger('', [], []); $monologLogger = new Logger('');
foreach ($monologLogger->getLevels() as $levelName => $level) { foreach ($monologLogger->getLevels() as $levelName => $level) {
$levels[] = [$levelName, $level]; $levels[] = array($levelName, $level);
} }
return $levels; return $levels;
@@ -36,15 +36,15 @@ class PsrHandlerTest extends TestCase
*/ */
public function testHandlesAllLevels($levelName, $level) public function testHandlesAllLevels($levelName, $level)
{ {
$message = 'Hello, world!'; $message = 'Hello, world! ' . $level;
$context = ['foo' => 'bar']; $context = array('foo' => 'bar', 'level' => $level);
$psrLogger = $this->getMock('Psr\Log\NullLogger'); $psrLogger = $this->getMock('Psr\Log\NullLogger');
$psrLogger->expects($this->once()) $psrLogger->expects($this->once())
->method(strtolower($levelName)) ->method('log')
->with($message, $context); ->with(strtolower($levelName), $message, $context);
$handler = new PsrHandler($psrLogger); $handler = new PsrHandler($psrLogger);
$handler->handle(['level' => $level, 'level_name' => $levelName, 'message' => $message, 'context' => $context]); $handler->handle(array('level' => $level, 'level_name' => $levelName, 'message' => $message, 'context' => $context));
} }
} }