From d3e6ce21047f62f65b1db69147b1d8ba130abf51 Mon Sep 17 00:00:00 2001
From: Awilum <awilum@msn.com>
Date: Mon, 12 Nov 2012 22:34:41 +0200
Subject: [PATCH] Menu Plugin: general js refactoring

---
 plugins/box/menu/js/menu.js                  | 23 ++++++++++++++++++++
 plugins/box/menu/menu.admin.php              | 23 +++-----------------
 plugins/box/menu/views/backend/add.view.php  |  4 ++--
 plugins/box/menu/views/backend/edit.view.php |  4 ++--
 4 files changed, 30 insertions(+), 24 deletions(-)
 create mode 100644 plugins/box/menu/js/menu.js

diff --git a/plugins/box/menu/js/menu.js b/plugins/box/menu/js/menu.js
new file mode 100644
index 0000000..958ba06
--- /dev/null
+++ b/plugins/box/menu/js/menu.js
@@ -0,0 +1,23 @@
+if (typeof $.monstra == 'undefined') $.monstra = {};
+
+$.monstra.menu = {
+
+    init: function() { },
+
+    selectPage: function (slug, title) {
+        $('input[name=menu_item_link]').val(slug);
+        $('input[name=menu_item_name]').val(title);
+        $('#selectPageModal').modal('hide');
+    },
+
+    selectCategory: function (name) {
+        $('input[name=menu_item_category]').val(name);
+        $('#selectCategoryModal').modal('hide');
+    }
+
+};
+
+
+$(document).ready(function(){
+    $.monstra.menu.init();
+});
\ No newline at end of file
diff --git a/plugins/box/menu/menu.admin.php b/plugins/box/menu/menu.admin.php
index d2f7908..00d1dee 100644
--- a/plugins/box/menu/menu.admin.php
+++ b/plugins/box/menu/menu.admin.php
@@ -3,7 +3,8 @@
     // Add plugin navigation link
     Navigation::add(__('Menu', 'menu'), 'content', 'menu', 3);
 
-    Action::add('admin_header', 'MenuAdmin::headers');
+    // Add Plugin Javascript
+    Javascript::add('plugins/box/menu/js/menu.js', 'backend');
 
 
     class MenuAdmin extends Backend {
@@ -18,26 +19,8 @@
 
 
         /**
-         * Headers
+         * Main 
          */
-        public static function headers() {
-            echo ("
-                <script> 
-                    function selectPage(slug, title) {
-                        $('input[name=menu_item_link]').val(slug);
-                        $('input[name=menu_item_name]').val(title);
-                        $('#selectPageModal').modal('hide');
-                    }
-
-                    function selectCategory(name) {
-                        $('input[name=menu_item_category]').val(name);
-                        $('#selectCategoryModal').modal('hide');
-                    }
-                </script>
-            ");
-        }
-        
-
         public static function main() {
 
             // Get menu table
diff --git a/plugins/box/menu/views/backend/add.view.php b/plugins/box/menu/views/backend/add.view.php
index 685b2f7..e4ccf38 100644
--- a/plugins/box/menu/views/backend/add.view.php
+++ b/plugins/box/menu/views/backend/add.view.php
@@ -61,7 +61,7 @@
                 <li><?php echo (!empty($page['parent'])) ? Html::nbsp().Html::arrow('right').Html::nbsp(2) : '' ; ?><a href="javascript:;" onclick="selectPage('<?php echo (empty($page['parent'])) ? $page['slug'] : $page['parent'].'/'.$page['slug'] ; ?>', '<?php echo $page['title']; ?>');"><?php echo $page['title']; ?></a></li>
             <?php } ?>
             <?php if (count($components_list) > 0) foreach($components_list as $component) { ?>
-                <li><a href="javascript:;" onclick="selectPage('<?php echo Text::lowercase($component); ?>', '<?php echo __($component); ?>');"><?php echo __($component); ?></a></li>
+                <li><a href="javascript:;" onclick="$.monstra.menu.selectPage('<?php echo Text::lowercase($component); ?>', '<?php echo __($component); ?>');"><?php echo __($component); ?></a></li>
             <?php } ?>
             </ul>
         </p>
@@ -77,7 +77,7 @@
         <p>
             <ul class="unstyled">
             <?php if (count($categories) > 0) foreach($categories as $category) { ?>
-                <li><a href="javascript:;" onclick="selectCategory('<?php echo $category; ?>');"><?php echo $category; ?></a></li>
+                <li><a href="javascript:;" onclick="$.monstra.menu.selectCategory('<?php echo $category; ?>');"><?php echo $category; ?></a></li>
             <?php } ?>
             </ul>
         </p>
diff --git a/plugins/box/menu/views/backend/edit.view.php b/plugins/box/menu/views/backend/edit.view.php
index 49a4baf..177cb8d 100644
--- a/plugins/box/menu/views/backend/edit.view.php
+++ b/plugins/box/menu/views/backend/edit.view.php
@@ -61,7 +61,7 @@
                 <li><?php echo (!empty($page['parent'])) ? Html::nbsp().Html::arrow('right').Html::nbsp(2) : '' ; ?><a href="javascript:;" onclick="selectPage('<?php echo (empty($page['parent'])) ? $page['slug'] : $page['parent'].'/'.$page['slug'] ; ?>', '<?php echo $page['title']; ?>');"><?php echo $page['title']; ?></a></li>
             <?php } ?>
             <?php if (count($components_list) > 0) foreach($components_list as $component) { ?>
-                <li><a href="javascript:;" onclick="selectPage('<?php echo Text::lowercase($component); ?>', '<?php echo __($component); ?>');"><?php echo __($component); ?></a></li>
+                <li><a href="javascript:;" onclick="$.monstra.menu.selectPage('<?php echo Text::lowercase($component); ?>', '<?php echo __($component); ?>');"><?php echo __($component); ?></a></li>
             <?php } ?>
             </ul>
         </p>
@@ -78,7 +78,7 @@
         <p>
             <ul class="unstyled">
             <?php if (count($categories) > 0) foreach($categories as $category) { ?>
-                <li><a href="javascript:;" onclick="selectCategory('<?php echo $category; ?>');"><?php echo $category; ?></a></li>
+                <li><a href="javascript:;" onclick="$.monstra.menu.selectCategory('<?php echo $category; ?>');"><?php echo $category; ?></a></li>
             <?php } ?>
             </ul>
         </p>