2010-03-06 05:40:38 +01:00
|
|
|
<?php
|
|
|
|
/**
|
|
|
|
*
|
2014-05-27 20:18:06 +02:00
|
|
|
* This file is part of the phpBB Forum Software package.
|
|
|
|
*
|
|
|
|
* @copyright (c) phpBB Limited <https://www.phpbb.com>
|
|
|
|
* @license GNU General Public License, version 2 (GPL-2.0)
|
|
|
|
*
|
|
|
|
* For full copyright and license information, please see
|
|
|
|
* the docs/CREDITS.txt file.
|
2010-03-06 05:40:38 +01:00
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
class phpbb_request_test extends phpbb_test_case
|
|
|
|
{
|
2016-03-10 14:42:47 +01:00
|
|
|
/** @var \phpbb\request\type_cast_helper_interface */
|
2010-03-13 11:28:41 +01:00
|
|
|
private $type_cast_helper;
|
2016-03-10 14:42:47 +01:00
|
|
|
|
|
|
|
/** @var \phpbb\request\request */
|
2010-03-06 05:40:38 +01:00
|
|
|
private $request;
|
|
|
|
|
2018-12-30 11:36:08 +01:00
|
|
|
protected function setUp(): void
|
2010-03-06 05:40:38 +01:00
|
|
|
{
|
|
|
|
// populate super globals
|
|
|
|
$_POST['test'] = 1;
|
|
|
|
$_GET['test'] = 2;
|
|
|
|
$_COOKIE['test'] = 3;
|
|
|
|
$_REQUEST['test'] = 3;
|
|
|
|
$_GET['unset'] = '';
|
2012-08-15 14:20:40 +01:00
|
|
|
$_FILES['test'] = array(
|
|
|
|
'name' => 'file',
|
|
|
|
'tmp_name' => 'tmp',
|
|
|
|
'size' => 256,
|
|
|
|
'type' => 'application/octet-stream',
|
|
|
|
'error' => UPLOAD_ERR_OK,
|
|
|
|
);
|
2010-03-06 05:40:38 +01:00
|
|
|
|
2011-08-06 19:47:12 +02:00
|
|
|
$_SERVER['HTTP_HOST'] = 'example.com';
|
|
|
|
$_SERVER['HTTP_ACCEPT'] = 'application/json';
|
|
|
|
$_SERVER['HTTP_SOMEVAR'] = '<value>';
|
|
|
|
|
2017-03-19 21:46:20 +07:00
|
|
|
$this->type_cast_helper = $this->createMock('\phpbb\request\type_cast_helper_interface');
|
2013-09-10 14:01:09 +02:00
|
|
|
$this->request = new \phpbb\request\request($this->type_cast_helper);
|
2010-03-06 05:40:38 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function test_toggle_super_globals()
|
|
|
|
{
|
|
|
|
$this->assertTrue($this->request->super_globals_disabled(), 'Superglobals were not disabled');
|
|
|
|
|
|
|
|
$this->request->enable_super_globals();
|
|
|
|
|
|
|
|
$this->assertFalse($this->request->super_globals_disabled(), 'Superglobals were not enabled');
|
|
|
|
|
|
|
|
$this->assertEquals(1, $_POST['test'], 'Checking $_POST after enable_super_globals');
|
|
|
|
$this->assertEquals(2, $_GET['test'], 'Checking $_GET after enable_super_globals');
|
|
|
|
$this->assertEquals(3, $_COOKIE['test'], 'Checking $_COOKIE after enable_super_globals');
|
|
|
|
$this->assertEquals(3, $_REQUEST['test'], 'Checking $_REQUEST after enable_super_globals');
|
2012-08-15 14:20:40 +01:00
|
|
|
$this->assertEquals(256, $_FILES['test']['size']);
|
2010-03-06 05:40:38 +01:00
|
|
|
|
|
|
|
$_POST['x'] = 2;
|
|
|
|
$this->assertEquals($_POST, $GLOBALS['_POST'], 'Checking whether $_POST can still be accessed via $GLOBALS[\'_POST\']');
|
|
|
|
}
|
|
|
|
|
2011-08-06 19:47:12 +02:00
|
|
|
public function test_server()
|
|
|
|
{
|
|
|
|
$this->assertEquals('example.com', $this->request->server('HTTP_HOST'));
|
|
|
|
}
|
|
|
|
|
|
|
|
public function test_server_escaping()
|
|
|
|
{
|
|
|
|
$this->type_cast_helper
|
|
|
|
->expects($this->once())
|
|
|
|
->method('recursive_set_var')
|
|
|
|
->with(
|
|
|
|
$this->anything(),
|
|
|
|
'',
|
2011-08-18 23:19:48 +02:00
|
|
|
true
|
2011-08-06 19:47:12 +02:00
|
|
|
);
|
|
|
|
|
|
|
|
$this->request->server('HTTP_SOMEVAR');
|
|
|
|
}
|
|
|
|
|
|
|
|
public function test_header()
|
|
|
|
{
|
|
|
|
$this->assertEquals('application/json', $this->request->header('Accept'));
|
|
|
|
}
|
|
|
|
|
|
|
|
public function test_header_escaping()
|
|
|
|
{
|
|
|
|
$this->type_cast_helper
|
|
|
|
->expects($this->once())
|
|
|
|
->method('recursive_set_var')
|
|
|
|
->with(
|
|
|
|
$this->anything(),
|
|
|
|
'',
|
|
|
|
true
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->request->header('SOMEVAR');
|
|
|
|
}
|
|
|
|
|
2012-08-20 21:40:53 +01:00
|
|
|
public function test_file()
|
|
|
|
{
|
|
|
|
$file = $this->request->file('test');
|
|
|
|
$this->assertEquals('file', $file['name']);
|
|
|
|
$this->assertEquals('tmp', $file['tmp_name']);
|
|
|
|
$this->assertEquals(256, $file['size']);
|
|
|
|
$this->assertEquals('application/octet-stream', $file['type']);
|
|
|
|
$this->assertEquals(UPLOAD_ERR_OK, $file['error']);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function test_file_not_exists()
|
|
|
|
{
|
|
|
|
$file = $this->request->file('404');
|
|
|
|
$this->assertTrue(is_array($file));
|
|
|
|
$this->assertTrue(empty($file));
|
|
|
|
}
|
|
|
|
|
2010-03-06 05:40:38 +01:00
|
|
|
/**
|
|
|
|
* Checks that directly accessing $_POST will trigger
|
|
|
|
* an error.
|
|
|
|
*/
|
|
|
|
public function test_disable_post_super_global()
|
|
|
|
{
|
|
|
|
$this->setExpectedTriggerError(E_USER_ERROR);
|
|
|
|
$_POST['test'] = 3;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function test_is_set_post()
|
|
|
|
{
|
|
|
|
$this->assertTrue($this->request->is_set_post('test'));
|
|
|
|
$this->assertFalse($this->request->is_set_post('unset'));
|
|
|
|
}
|
|
|
|
|
2011-07-13 19:20:16 +02:00
|
|
|
public function test_is_ajax_without_ajax()
|
|
|
|
{
|
|
|
|
$this->assertFalse($this->request->is_ajax());
|
|
|
|
}
|
|
|
|
|
|
|
|
public function test_is_ajax_with_ajax()
|
|
|
|
{
|
|
|
|
$this->request->enable_super_globals();
|
|
|
|
$_SERVER['HTTP_X_REQUESTED_WITH'] = 'XMLHttpRequest';
|
2013-09-10 14:01:09 +02:00
|
|
|
$this->request = new \phpbb\request\request($this->type_cast_helper);
|
2011-07-13 19:20:16 +02:00
|
|
|
|
|
|
|
$this->assertTrue($this->request->is_ajax());
|
|
|
|
}
|
|
|
|
|
2016-03-10 14:42:47 +01:00
|
|
|
public function data_is_secure()
|
|
|
|
{
|
|
|
|
return array(
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'HTTPS' => 'on',
|
|
|
|
),
|
|
|
|
true,
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'HTTPS' => '1',
|
|
|
|
),
|
|
|
|
true,
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'HTTPS' => 'yes',
|
|
|
|
),
|
|
|
|
true,
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'HTTPS' => 1,
|
|
|
|
),
|
|
|
|
true,
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'HTTPS' => 'off',
|
|
|
|
),
|
|
|
|
false,
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'HTTPS' => '0',
|
|
|
|
),
|
|
|
|
false,
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'HTTPS' => 0,
|
|
|
|
),
|
|
|
|
false,
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'HTTPS' => '',
|
|
|
|
),
|
|
|
|
false,
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'HTTPS' => 'off',
|
|
|
|
'HTTP_X_FORWARDED_PROTO' => 'https',
|
|
|
|
),
|
|
|
|
true,
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'HTTPS' => 'on',
|
|
|
|
'HTTP_X_FORWARDED_PROTO' => 'http',
|
|
|
|
),
|
|
|
|
true,
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'HTTPS' => 'off',
|
|
|
|
'HTTP_X_FORWARDED_PROTO' => 'http',
|
|
|
|
),
|
|
|
|
false,
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'HTTP_X_FORWARDED_PROTO' => 'http',
|
|
|
|
),
|
|
|
|
false,
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'HTTP_X_FORWARDED_PROTO' => 'https',
|
|
|
|
),
|
|
|
|
true,
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'HTTPS' => 'on',
|
|
|
|
'HTTP_X_FORWARDED_PROTO' => 'http',
|
|
|
|
),
|
|
|
|
true,
|
|
|
|
),
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @dataProvider data_is_secure
|
|
|
|
*/
|
|
|
|
public function test_is_secure($server_data, $expected)
|
2011-08-18 22:21:50 +02:00
|
|
|
{
|
|
|
|
$this->assertFalse($this->request->is_secure());
|
|
|
|
|
|
|
|
$this->request->enable_super_globals();
|
2016-03-10 14:42:47 +01:00
|
|
|
$_SERVER = $server_data;
|
2013-09-10 14:01:09 +02:00
|
|
|
$this->request = new \phpbb\request\request($this->type_cast_helper);
|
2011-08-18 22:21:50 +02:00
|
|
|
|
2016-03-10 14:42:47 +01:00
|
|
|
$this->assertSame($expected, $this->request->is_secure());
|
2011-08-18 22:21:50 +02:00
|
|
|
}
|
|
|
|
|
2010-03-06 05:40:38 +01:00
|
|
|
public function test_variable_names()
|
|
|
|
{
|
|
|
|
$expected = array('test', 'unset');
|
|
|
|
$result = $this->request->variable_names();
|
|
|
|
$this->assertEquals($expected, $result);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Makes sure super globals work properly after these tests
|
|
|
|
*/
|
2018-12-30 11:36:08 +01:00
|
|
|
protected function tearDown(): void
|
2010-03-06 05:40:38 +01:00
|
|
|
{
|
|
|
|
$this->request->enable_super_globals();
|
|
|
|
}
|
|
|
|
}
|