mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-27 13:35:13 +02:00
Code Issues Releases Wiki Activity

[feature/migrations] Basic reverting test

Browse Source 
PHPBB3-9737
This commit is contained in:
Nathan Guse
2013-01-10 13:52:11 -06:00
parent ddb1eaab68
commit 00385aa742
3 changed files with 115 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
tests/dbal/migration/revert.php Normal file
View File

@ -0,0 +1,45 @@
<?php
/**
*
* @package testing
* @copyright (c) 2011 phpBB Group
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
*/
class phpbb_dbal_migration_revert extends phpbb_db_migration
{
function depends_on()
{
return array();
}
function update_schema()
{
return array(
'add_columns' => array(
'phpbb_config' => array(
'bar_column' => array('UINT', 1),
),
),
);
}
function revert_schema()
{
return array(
'drop_columns' => array(
'phpbb_config' => array(
'bar_column',
),
),
);
}
function update_data()
{
return array(
array('config.add', array('foobartest', 0)),
);
}
}

16
tests/dbal/migration/revert_with_dependency.php Normal file
View File

@ -0,0 +1,16 @@
<?php
/**
*
* @package testing
* @copyright (c) 2011 phpBB Group
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
*/
class phpbb_dbal_migration_revert_with_dependency extends phpbb_db_migration
{
function depends_on()
{
return array('phpbb_dbal_migration_revert');
}
}

54
tests/dbal/migrator_test.php
View File

@ -16,6 +16,8 @@ require_once dirname(__FILE__) . '/migration/dummy.php';
require_once dirname(__FILE__) . '/migration/unfulfillable.php'; require_once dirname(__FILE__) . '/migration/unfulfillable.php';
require_once dirname(__FILE__) . '/migration/if.php'; require_once dirname(__FILE__) . '/migration/if.php';
require_once dirname(__FILE__) . '/migration/recall.php'; require_once dirname(__FILE__) . '/migration/recall.php';
require_once dirname(__FILE__) . '/migration/revert.php';
require_once dirname(__FILE__) . '/migration/revert_with_dependency.php';
class phpbb_dbal_migrator_test extends phpbb_database_test_case class phpbb_dbal_migrator_test extends phpbb_database_test_case
{ {
@ -102,6 +104,8 @@ class phpbb_dbal_migrator_test extends phpbb_database_test_case
"SELECT extra_column FROM phpbb_config WHERE config_name = 'foo'", "SELECT extra_column FROM phpbb_config WHERE config_name = 'foo'",
'Dummy migration was run, even though an unfulfillable migration was found.' 'Dummy migration was run, even though an unfulfillable migration was found.'
); );
$this->db_tools->sql_column_remove('phpbb_config', 'extra_column');
} }
public function test_if() public function test_if()
@ -150,4 +154,54 @@ class phpbb_dbal_migrator_test extends phpbb_database_test_case
$this->assertSame(10, $migrator_test_call_input); $this->assertSame(10, $migrator_test_call_input);
} }
public function test_revert()
{
// Make sure there are no other migrations in the db, this could cause issues
$this->db->sql_query("DELETE FROM phpbb_migrations");
$this->migrator->load_migration_state();
$this->migrator->set_migrations(array('phpbb_dbal_migration_revert', 'phpbb_dbal_migration_revert_with_dependency'));
$this->assertFalse($this->migrator->migration_installed('phpbb_dbal_migration_revert'));
$this->assertFalse($this->migrator->migration_installed('phpbb_dbal_migration_revert_with_dependency'));
// Install the migration first
while (!$this->migrator->finished())
{
$this->migrator->update();
}
$this->assertTrue($this->migrator->migration_installed('phpbb_dbal_migration_revert'));
$this->assertTrue($this->migrator->migration_installed('phpbb_dbal_migration_revert_with_dependency'));
$this->assertSqlResultEquals(
array(array('bar_column' => '1')),
"SELECT bar_column FROM phpbb_config WHERE config_name = 'foo'",
'Installing revert migration failed to create bar_column.'
);
$this->assertTrue(isset($this->config['foobartest']));
while ($this->migrator->migration_installed('phpbb_dbal_migration_revert'))
{
$this->migrator->revert('phpbb_dbal_migration_revert');
}
$this->assertFalse($this->migrator->migration_installed('phpbb_dbal_migration_revert'));
$this->assertFalse($this->migrator->migration_installed('phpbb_dbal_migration_revert_with_dependency'));
$this->assertFalse(isset($this->config['foobartest']));
try
{
// Should cause an error
$this->assertSqlResultEquals(
false,
"SELECT bar_column FROM phpbb_config WHERE config_name = 'foo'",
'Revert did not remove bar_column.'
);
}
catch (Exception $e) {}
}
} }