mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-11 03:04:09 +02:00
Code Issues Releases Wiki Activity

[feature/avatars] Remove $request property and pass as argument if needed

Browse Source 
Remove the $request property from the phpbb_avatar_driver class and rather
pass it as function argument if it's needed in a function. Currently this
is only the case for the class methods prepare_form() and process_form().

PHPBB3-10018
This commit is contained in:
Marc Alexander
2013-01-07 22:49:48 +01:00
parent 8867cb60b1
commit 023d7a972d
12 changed files with 41 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
phpBB/includes/avatar/driver/interface.php
View File

@@ -50,6 +50,7 @@ interface phpbb_avatar_driver_interface
/**
* Prepare form for changing the settings of this avatar
*
* @param phpbb_request $request Request object
* @param phpbb_template $template Template object
* @param array $row User data or group data that has been cleaned with
* phpbb_avatar_manager::clean_row
@@ -60,7 +61,7 @@ interface phpbb_avatar_driver_interface
*
* @return bool True if form has been successfully prepared
*/
public function prepare_form($template, $row, &$error);
public function prepare_form($request, $template, $row, &$error);
/**
* Prepare form for changing the acp settings of this avatar
@@ -74,6 +75,7 @@ interface phpbb_avatar_driver_interface
/**
* Process form data
*
* @param phpbb_request $request Request object
* @param phpbb_template $template Template object
* @param array $row User data or group data that has been cleaned with
* phpbb_avatar_manager::clean_row
@@ -85,7 +87,7 @@ interface phpbb_avatar_driver_interface
* @return array Array containing the avatar data as follows:
* ['avatar'], ['avatar_width'], ['avatar_height']
*/
public function process_form($template, $row, &$error);
public function process_form($request, $template, $row, &$error);
/**
* Delete avatar