mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-25 12:35:55 +02:00
Code Issues Releases Wiki Activity

[ticket/12597] Typing corrections and improvement of code consistency

Browse Source 
PHPBB3-12597
This commit is contained in:
LEZY Thomas
2014-05-29 17:26:58 +02:00
parent 7508d2b546
commit 03e0e736ab
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
phpBB/phpbb/console/command/cron/run.php
View File

@ -60,7 +60,7 @@ class run extends \phpbb\console\command\command
} }
/** /**
* Executes the function. * Executes the command cron:run.
* *
* Tries to acquire the cron lock, then if no argument has been given runs all ready cron tasks. * Tries to acquire the cron lock, then if no argument has been given runs all ready cron tasks.
* If the cron lock can not be obtained, an error message is printed * If the cron lock can not be obtained, an error message is printed
@ -89,8 +89,7 @@ class run extends \phpbb\console\command\command
} }
else else
{ {
$this->run_all($input, $output); return $this->run_all($input, $output);
return 0;
} }
} }
else else
@ -101,15 +100,15 @@ class run extends \phpbb\console\command\command
} }
/* /*
* Executes the command in the case when no argument was given. * Executes all ready cron tasks.
* *
* If verbose mode is set, an info message will be printed if their is no task to * If verbose mode is set, an info message will be printed if there is no task to
* be run, or else for each starting task. * be run, or else for each starting task.
* *
* @see execute * @see execute
* @param InputInterface $input The input stream used to get the argument and verboe option. * @param InputInterface $input The input stream used to get the argument and verboe option.
* @param OutputInterface $output The output stream, used for printing verbose-mode and error information. * @param OutputInterface $output The output stream, used for printing verbose-mode and error information.
* @return null * @return int 0
*/ */
protected function run_all(InputInterface $input, OutputInterface $output) protected function run_all(InputInterface $input, OutputInterface $output)
{ {
@ -134,13 +133,15 @@ class run extends \phpbb\console\command\command
$output->writeln('<info>' . $this->user->lang('CRON_NO_TASK') . '</info>'); $output->writeln('<info>' . $this->user->lang('CRON_NO_TASK') . '</info>');
} }
} }
$this->lock_db->release(); $this->lock_db->release();
return 0;
} }
/* /*
* Executes the command in the case where an argument is given. * Executes a given cron task, if it is ready.
* *
* If their is a task whose name matches the argument, it is run and 0 is returned. * If there is a task whose name matches the argument, it is run and 0 is returned.
* and if verbose mode is set, print an info message with the name of the task. * and if verbose mode is set, print an info message with the name of the task.
* If there is no task matching $task_name, the function prints an error message * If there is no task matching $task_name, the function prints an error message
* and returns with status 2. * and returns with status 2.
@ -162,11 +163,13 @@ class run extends \phpbb\console\command\command
} }
$task->run(); $task->run();
$this->lock_db->release();
return 0; return 0;
} }
else else
{ {
$output->writeln('<error>' . $this->user->lang('CRON_NO_SUCH_TASK') . '</error>'); $output->writeln('<error>' . $this->user->lang('CRON_NO_SUCH_TASK') . '</error>');
$this->lock_db->release();
return 2; return 2;
} }
} }