mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-30 21:40:43 +02:00
Code Issues Releases Wiki Activity

[ticket/11103] Fix some various issues, better comments

Browse Source 
PHPBB3-11103
This commit is contained in:
Nathan Guse
2013-01-15 12:10:07 -06:00
parent 51e0f002ee
commit 07282a30ae
8 changed files with 190 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/mock/notifications_notification_manager.php
View File

@@ -44,7 +44,7 @@ class phpbb_mock_notifications_notification_manager extends phpbb_notification_m
{
$item_type = 'phpbb_notification_type_' . $item_type;
$item = new $item_type($this->user_loader, $this->db, $this->cache, $this->user, $this->auth, $this->config, $this->phpbb_root_path, $this->php_ext, $this->notifications_table, $this->user_notifications_table);
$item = new $item_type($this->user_loader, $this->db, $this->cache, $this->user, $this->auth, $this->config, $this->phpbb_root_path, $this->php_ext, $this->notification_types_table, $this->notifications_table, $this->user_notifications_table);
$item->set_notification_manager($this);
@@ -60,7 +60,7 @@ class phpbb_mock_notifications_notification_manager extends phpbb_notification_m
{
$method_name = 'phpbb_notification_method_' . $method_name;
$method = new $method_name($this->user_loader, $this->db, $this->cache, $this->user, $this->auth, $this->config, $this->phpbb_root_path, $this->php_ext, $this->notifications_table, $this->user_notifications_table);
$method = new $method_name($this->user_loader, $this->db, $this->cache, $this->user, $this->auth, $this->config, $this->phpbb_root_path, $this->php_ext, $this->notification_types_table, $this->notifications_table, $this->user_notifications_table);
$method->set_notification_manager($this);

4
tests/notification/ext/test/notification/type/test.php
View File

@@ -39,7 +39,7 @@ class phpbb_notification_type_test extends phpbb_notification_type_base
public function create_insert_array($post, $pre_create_data = array())
{
$this->time = $post['post_time'];
$this->notification_time = $post['post_time'];
return parent::create_insert_array($post, $pre_create_data);
}
@@ -51,7 +51,7 @@ class phpbb_notification_type_test extends phpbb_notification_type_base
// Unset data unique to each row
unset(
$data['notification_id'],
$data['unread'],
$data['notification_read'],
$data['user_id']
);

5
tests/notification/notification.php
View File

@@ -6,7 +6,7 @@
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
*
*/
//calls: [ [set_notification_manager, [@notification_manager]] ]
class phpbb_notification_test extends phpbb_database_test_case
{
protected $notifications, $db, $container, $user, $config, $auth, $cache;
@@ -52,6 +52,7 @@ class phpbb_notification_test extends phpbb_database_test_case
$this->user,
$phpbb_root_path,
$phpEx,
'phpbb_notification_types',
'phpbb_notifications',
'phpbb_user_notifications'
);
@@ -91,7 +92,7 @@ class phpbb_notification_test extends phpbb_database_test_case
{
global $phpbb_root_path, $phpEx;
return new $type($this->user_loader, $this->db, $this->cache, $this->user, $this->auth, $this->config, $phpbb_root_path, $phpEx, 'phpbb_notifications', 'phpbb_user_notifications');
return new $type($this->user_loader, $this->db, $this->cache, $this->user, $this->auth, $this->config, $phpbb_root_path, $phpEx, 'phpbb_notification_types', 'phpbb_notifications', 'phpbb_user_notifications');
}
public function test_get_subscription_types()