[ticket/17176] Update psalm expected PHP version and add missing return type

PHPBB3-17176

.github/workflows/tests.yml

@@ -118,8 +118,8 @@ jobs:
                       db: "mariadb:10.10"
                     - php: '8.1'
                       db: "mariadb:10.11"
-                    - php: '8.1'
-                      db: "mariadb:11.0"
+                    # - php: '8.1' # currently disabled
+                    #   db: "mariadb:11.0"
                     - php: '8.1'
                       db: "mysql:5.7"
                       db_alias: "MySQL Slow Tests"

phpBB/phpbb/console/application.php

@@ -45,7 +45,7 @@ class application extends \Symfony\Component\Console\Application
 	/**
 	* {@inheritdoc}
 	*/
-	protected function getDefaultInputDefinition()
+	protected function getDefaultInputDefinition(): InputDefinition
 	{
 		$input_definition = parent::getDefaultInputDefinition();
 

psalm.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <psalm
     errorLevel="5"
-    phpVersion="7.3"
+    phpVersion="8.1"
     resolveFromConfigFile="true"
     autoloader="build/psalm_bootstrap.php"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"