1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-06 16:56:44 +02:00

[feature/system-cron] Reorganized cron task parametrization.

PHPBB3-9596
This commit is contained in:
Oleg Pudeyev
2010-04-17 06:32:15 -04:00
parent 0f9b3bcc27
commit 0cfbdcc744
4 changed files with 107 additions and 34 deletions

View File

@@ -24,11 +24,25 @@ if (!defined('IN_PHPBB'))
*/
class cron_task_wrapper
{
/**
* Wraps a task $task, which must implement cron_task interface.
*/
public function __construct($task)
{
$this->task = $task;
}
/**
* Returns whether this task is parametrized.
*
* Parametrized tasks accept parameters during initialization and must
* normally be scheduled with parameters.
*/
public function is_parametrized()
{
return $this->task instanceof parametrized_cron_task;
}
/**
* Returns whether the wrapped task is ready to run.
*
@@ -49,12 +63,28 @@ class cron_task_wrapper
return preg_replace('/^cron_task_/', '', $class);
}
/**
* Returns a url through which this task may be invoked via web.
*/
public function get_url()
{
global $phpbb_root_path, $phpEx;
$name = $this->get_name();
$url = append_sid($phpbb_root_path . 'cron.' . $phpEx, 'cron_type=' . $name);
if ($this->is_parametrized())
{
$params = $this->task->get_parameters();
$extra = '';
foreach ($params as $key => $value)
{
$extra .= '&' . $key . '=' . urlencode($value);
}
}
else
{
$extra = '';
}
$url = append_sid($phpbb_root_path . 'cron.' . $phpEx, 'cron_type=' . $name . $extra);
return $url;
}