mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-24 17:22:55 +02:00
Code Issues Releases Wiki Activity

[ticket/15540] Decouple create_index and delete_index from acp

Browse Source 
PHPBB3-15540
This commit is contained in:
rubencm
2021-03-22 21:54:36 +01:00
parent 9dac66071e
commit 16220058d3
7 changed files with 166 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
phpBB/phpbb/search/backend/fulltext_sphinx.php
View File

@@ -607,21 +607,19 @@ class fulltext_sphinx implements search_backend_interface
}
/**
* Nothing needs to be destroyed
*/
* Nothing needs to be destroyed
*/
public function tidy()
{
$this->config->set('search_last_gc', time(), false);
}
/**
* Create sphinx table
*
* @return string|bool error string is returned incase of errors otherwise false
*/
public function create_index($acp_module, $u_action)
* {@inheritdoc}
*/
public function create_index(int &$post_counter = null): ?array
{
if (!$this->index_created())
if ($this->index_created())
{
$table_data = array(
'COLUMNS' => array(
@@ -643,30 +641,23 @@ class fulltext_sphinx implements search_backend_interface
$this->db->sql_query($sql);
}
return false;
return null;
}
/**
* Drop sphinx table
*
* @return string|bool error string is returned incase of errors otherwise false
* {@inheritdoc}
*/
public function delete_index($acp_module, $u_action)
public function delete_index(int &$post_counter = null): ?array
{
if (!$this->index_created())
{
return false;
if ($this->index_created()) {
$this->db_tools->sql_table_drop(SPHINX_TABLE);
}
$this->db_tools->sql_table_drop(SPHINX_TABLE);
return false;
return null;
}
/**
* Returns true if the sphinx table was created
*
* @return bool true if sphinx table was created
* {@inheritdoc}
*/
public function index_created($allow_new_files = true)
{