mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-30 21:40:43 +02:00
Code Issues Releases Wiki Activity

[ticket/13358] Do not pass variables by reference

Browse Source 
PHPBB3-13358
This commit is contained in:
Marc Alexander
2014-11-21 23:16:22 +01:00
parent 352648f173
commit 171837eefe
3 changed files with 21 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
phpBB/includes/functions_admin.php
View File

@@ -2990,11 +2990,13 @@ function get_remote_file($host, $directory, $filename, &$errstr, &$errno, $port
global $phpbb_container;
// Get file downloader and assign $errstr and $errno
$file_downloader = $phpbb_container->get('file_downloader')
->set_error_string($errstr)
->set_error_number($errno);
$file_downloader = $phpbb_container->get('file_downloader');
return $file_downloader->get($host, $directory, $filename, $port, $timeout);
$file_data = $file_downloader->get($host, $directory, $filename, $port, $timeout);
$errstr = $file_downloader->get_error_string();
$errno = $file_downloader->get_error_number();
return $file_data;
}
/*