mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-10 02:36:38 +02:00
Code Issues Releases Wiki Activity

[ticket/13358] Do not pass variables by reference

Browse Source 
PHPBB3-13358
This commit is contained in:
Marc Alexander
2014-11-21 23:16:22 +01:00
parent 352648f173
commit 171837eefe
3 changed files with 21 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
phpBB/phpbb/version_helper.php
View File

@@ -254,9 +254,6 @@ class version_helper
}
else if ($info === false || $force_update)
{
$errstr = $errno = '';
$this->file_downloader->set_error_number($errno)
->set_error_string($errstr);
try {
$info = $this->file_downloader->get($this->host, $this->path, $this->file);
}
@@ -264,10 +261,11 @@ class version_helper
{
throw new \RuntimeException(call_user_func_array(array($this->user, 'lang'), $exception->getMessage()));
}
$error_string = $this->file_downloader->get_error_string();
if (!empty($errstr))
if (!empty($error_string))
{
throw new \RuntimeException($errstr);
throw new \RuntimeException($error_string);
}
$info = json_decode($info, true);