mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-24 20:13:22 +01:00
Code Issues Releases Wiki Activity

[ticket/12012] Return SQL statements for index drop/create

Browse Source 
Otherwise we recreate the index before changing the column

PHPBB3-12012
This commit is contained in:
Joas Schilling 2014-04-13 16:43:57 +02:00
parent e2784d01ce
commit 190b4282df
1 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
phpBB/phpbb/db/tools.php
View File

@ -2336,21 +2336,32 @@ class tools
case 'mssql': case 'mssql':
case 'mssqlnative': case 'mssqlnative':
// We need the data here
$old_return_statements = $this->return_statements;
$this->return_statements = true;
$indexes = $this->mssql_get_existing_indexes($table_name, $column_name); $indexes = $this->mssql_get_existing_indexes($table_name, $column_name);
// Drop any indexes
if (!empty($indexes)) if (!empty($indexes))
{ {
foreach ($indexes as $index_name => $index_data) foreach ($indexes as $index_name => $index_data)
{ {
$this->sql_index_drop($table_name, $index_name); $result = $this->sql_index_drop($table_name, $index_name);
$statements = array_merge($statements, $result);
} }
} }
$statements = $this->mssql_drop_default_constraints($table_name, $column_name); // Drop default value constraint
$result = $this->mssql_drop_default_constraints($table_name, $column_name);
$statements = array_merge($statements, $result);
// Change the column
$statements[] = 'ALTER TABLE [' . $table_name . '] ALTER COLUMN [' . $column_name . '] ' . $column_data['column_type_sql']; $statements[] = 'ALTER TABLE [' . $table_name . '] ALTER COLUMN [' . $column_name . '] ' . $column_data['column_type_sql'];
if (!empty($column_data['default'])) if (!empty($column_data['default']))
{ {
// Add new default value constraint
$statements[] = 'ALTER TABLE [' . $table_name . '] ADD CONSTRAINT [DF_' . $table_name . '_' . $column_name . '_1] ' . $this->db->sql_escape($column_data['default']) . ' FOR [' . $column_name . ']'; $statements[] = 'ALTER TABLE [' . $table_name . '] ADD CONSTRAINT [DF_' . $table_name . '_' . $column_name . '_1] ' . $this->db->sql_escape($column_data['default']) . ' FOR [' . $column_name . ']';
} }
@ -2359,9 +2370,12 @@ class tools
// Recreate indexes after we changed the column // Recreate indexes after we changed the column
foreach ($indexes as $index_name => $index_data) foreach ($indexes as $index_name => $index_data)
{ {
$this->sql_create_index($table_name, $index_name, $index_data); $result = $this->sql_create_index($table_name, $index_name, $index_data);
$statements = array_merge($statements, $result);
} }
} }
$this->return_statements = $old_return_statements;
break; break;
case 'mysql_40': case 'mysql_40':