From 205e098b38a00fb7fc50c8aa2d1f65c97bc70ef6 Mon Sep 17 00:00:00 2001 From: PayBas Date: Tue, 1 Apr 2014 14:23:58 +0200 Subject: [PATCH 1/3] [ticket/12339] Add Event core.page_header_after PHPBB3-12339 --- phpBB/includes/functions.php | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/phpBB/includes/functions.php b/phpBB/includes/functions.php index ebd676b17a..1e77b6cde4 100644 --- a/phpBB/includes/functions.php +++ b/phpBB/includes/functions.php @@ -4957,6 +4957,17 @@ function page_header($page_title = '', $display_online_list = true, $item_id = 0 'SITE_LOGO_IMG' => $user->img('site_logo'), )); + /** + * Execute code and/or overwrite _common_ template variables after they have been assigned. + * + * @event core.page_header_after + * @var string page_title Page title + * + * @since 3.1-B3 + */ + $vars = array('page_title'); + extract($phpbb_dispatcher->trigger_event('core.page_header_after', compact($vars))); + // application/xhtml+xml not used because of IE header('Content-type: text/html; charset=UTF-8'); From c6c5f7c874cb5ceaf0b06a44cff666b1050fe4ec Mon Sep 17 00:00:00 2001 From: PayBas Date: Fri, 4 Apr 2014 13:45:57 +0200 Subject: [PATCH 2/3] [ticket/12339] more complete params and updated _since version PHPBB3-12339 --- phpBB/includes/functions.php | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/phpBB/includes/functions.php b/phpBB/includes/functions.php index 1e77b6cde4..d2735c8e43 100644 --- a/phpBB/includes/functions.php +++ b/phpBB/includes/functions.php @@ -4962,10 +4962,16 @@ function page_header($page_title = '', $display_online_list = true, $item_id = 0 * * @event core.page_header_after * @var string page_title Page title - * - * @since 3.1-B3 + * @var bool display_online_list Do we display online users list + * @var string item Restrict online users to a certain + * session item, e.g. forum for + * session_forum_id + * @var int item_id Restrict online users to item id + * @var bool page_header_override Shall we return instead of running + * the rest of page_header() + * @since 3.1.0-b3 */ - $vars = array('page_title'); + $vars = array('page_title', 'display_online_list', 'item_id', 'item', 'page_header_override'); extract($phpbb_dispatcher->trigger_event('core.page_header_after', compact($vars))); // application/xhtml+xml not used because of IE From 084e6725f7ee6ddd1b4a0494ff2c65213a70f67b Mon Sep 17 00:00:00 2001 From: PayBas Date: Fri, 4 Apr 2014 18:26:20 +0200 Subject: [PATCH 3/3] [ticket/12339] removed return var need to learn more about events... evidently PHPBB3-12339 --- phpBB/includes/functions.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/phpBB/includes/functions.php b/phpBB/includes/functions.php index d2735c8e43..3dddbdca6b 100644 --- a/phpBB/includes/functions.php +++ b/phpBB/includes/functions.php @@ -4967,11 +4967,10 @@ function page_header($page_title = '', $display_online_list = true, $item_id = 0 * session item, e.g. forum for * session_forum_id * @var int item_id Restrict online users to item id - * @var bool page_header_override Shall we return instead of running - * the rest of page_header() + * * @since 3.1.0-b3 */ - $vars = array('page_title', 'display_online_list', 'item_id', 'item', 'page_header_override'); + $vars = array('page_title', 'display_online_list', 'item_id', 'item'); extract($phpbb_dispatcher->trigger_event('core.page_header_after', compact($vars))); // application/xhtml+xml not used because of IE