From 1ba0ae6e8530d3dab55ad1333c0d392eefa2d401 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sat, 19 Oct 2019 17:48:34 +0200 Subject: [PATCH] [ticket/16078] Try using retries for timeout issue The timeout only seems to occur on the first test so let's see what a retry can do to help with this issue. PHPBB3-16078 --- tests/test_framework/phpbb_ui_test_case.php | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/tests/test_framework/phpbb_ui_test_case.php b/tests/test_framework/phpbb_ui_test_case.php index 4d88d7d9cb..e7c9bd4d0b 100644 --- a/tests/test_framework/phpbb_ui_test_case.php +++ b/tests/test_framework/phpbb_ui_test_case.php @@ -158,7 +158,23 @@ class phpbb_ui_test_case extends phpbb_test_case public function visit($path) { - $this->getDriver()->get(self::$root_url . $path); + // Retry three times on curl issues, e.g. timeout + try + { + $this->getDriver()->get(self::$root_url . $path); + } + catch (Facebook\WebDriver\Exception\WebDriverCurlException $exception) + { + try + { + $this->getDriver()->get(self::$root_url . $path); + } + catch (Facebook\WebDriver\Exception\WebDriverCurlException $exception) + { + // Last try, throw exception after this one fails + $this->getDriver()->get(self::$root_url . $path); + } + } } static protected function recreate_database($config)