1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-23 11:28:33 +01:00

[ŧicket/11600] Split get driver tests into tests for all and only enabled ones

PHPBB3-11600
This commit is contained in:
Marc Alexander 2013-06-25 11:31:15 +02:00
parent 3703de63dd
commit 25acf3f74c

View File

@ -88,27 +88,51 @@ class phpbb_avatar_manager_test extends PHPUnit_Framework_TestCase
$this->assertEquals('avatar.driver.foobar', $drivers['avatar.driver.foobar']); $this->assertEquals('avatar.driver.foobar', $drivers['avatar.driver.foobar']);
} }
public function get_driver_data() public function get_driver_data_enabled()
{ {
return array( return array(
array('avatar.driver.foobar', 'avatar.driver.foobar', false),
array('avatar.driver.foo_wrong', NULL, false),
array('avatar.driver.foobar', 'avatar.driver.foobar'), array('avatar.driver.foobar', 'avatar.driver.foobar'),
array('avatar.driver.foo_wrong', NULL), array('avatar.driver.foo_wrong', NULL),
array('avatar.driver.local', 'avatar.driver.local', false), array('avatar.driver.foobar', 'avatar.driver.foobar'),
array(AVATAR_GALLERY, 'avatar.driver.local', false), array('avatar.driver.foo_wrong', NULL),
array(AVATAR_UPLOAD, 'avatar.driver.upload', false), array('avatar.driver.local', NULL),
array(AVATAR_REMOTE, 'avatar.driver.remote', false), array(AVATAR_GALLERY, NULL),
array(AVATAR_UPLOAD, NULL),
array(AVATAR_REMOTE, NULL),
array(AVATAR_GALLERY, NULL), array(AVATAR_GALLERY, NULL),
); );
} }
/** /**
* @dataProvider get_driver_data * @dataProvider get_driver_data_enabled
*/ */
public function test_get_driver($driver_name, $expected, $enabled_only = true) public function test_get_driver_enabled($driver_name, $expected)
{ {
$driver = $this->manager->get_driver($driver_name, $enabled_only); $driver = $this->manager->get_driver($driver_name);
$this->assertEquals($expected, $driver);
}
public function get_driver_data_all()
{
return array(
array('avatar.driver.foobar', 'avatar.driver.foobar'),
array('avatar.driver.foo_wrong', NULL),
array('avatar.driver.foobar', 'avatar.driver.foobar'),
array('avatar.driver.foo_wrong', NULL),
array('avatar.driver.local', 'avatar.driver.local'),
array(AVATAR_GALLERY, 'avatar.driver.local'),
array(AVATAR_UPLOAD, 'avatar.driver.upload'),
array(AVATAR_REMOTE, 'avatar.driver.remote'),
array(AVATAR_GALLERY, 'avatar.driver.local'),
);
}
/**
* @dataProvider get_driver_data_all
*/
public function test_get_driver_all($driver_name, $expected)
{
$driver = $this->manager->get_driver($driver_name, false);
$this->assertEquals($expected, $driver); $this->assertEquals($expected, $driver);
} }