1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-10 02:36:38 +02:00

[ticket/13454] Remove unused variables

Part 4

PHPBB3-13454
This commit is contained in:
Marc Alexander
2015-12-04 11:50:39 +01:00
parent 6c25ad4822
commit 266576c6a4
35 changed files with 41 additions and 78 deletions

View File

@@ -709,8 +709,6 @@ class acp_attachments
$forum_ids = array();
}
$extensions = array();
$sql = 'SELECT *
FROM ' . EXTENSIONS_TABLE . "
WHERE group_id = $group_id

View File

@@ -759,7 +759,7 @@ class acp_board
*/
function select_auth_method($selected_method, $key = '')
{
global $phpbb_root_path, $phpEx, $phpbb_container;
global $phpbb_container;
/* @var $auth_providers \phpbb\auth\provider_collection */
$auth_providers = $phpbb_container->get('auth.provider_collection');

View File

@@ -579,7 +579,7 @@ class acp_modules
*/
function make_module_select($select_id = false, $ignore_id = false, $ignore_acl = false, $ignore_nonpost = false, $ignore_emptycat = true, $ignore_noncat = false)
{
global $db, $user, $auth, $config;
global $db, $user;
$sql = 'SELECT module_id, module_enabled, module_basename, parent_id, module_langname, left_id, right_id, module_auth
FROM ' . MODULES_TABLE . "

View File

@@ -690,7 +690,7 @@ class acp_permissions
trigger_error($user->lang['NO_AUTH_OPERATION'] . adm_back_link($this->u_action), E_USER_WARNING);
}
$ug_id = $forum_id = 0;
$forum_id = 0;
// We loop through the auth settings defined in our submit
list($ug_id, ) = each($psubmit);

View File

@@ -549,11 +549,7 @@ class acp_profile
}
}
if (sizeof($error))
{
$submit = false;
}
else
if (!sizeof($error))
{
$step = (isset($_REQUEST['next'])) ? $step + 1 : ((isset($_REQUEST['prev'])) ? $step - 1 : $step);
}
@@ -775,7 +771,7 @@ class acp_profile
*/
function build_language_options(&$cp, $field_type, $action = 'create')
{
global $user, $config, $db, $phpbb_container, $request;
global $user, $config, $db, $request;
$default_lang_id = (!empty($this->edit_lang_id)) ? $this->edit_lang_id : $this->lang_defs['iso'][$config['default_lang']];

View File

@@ -551,7 +551,7 @@ class acp_search
function get_search_types()
{
global $phpbb_root_path, $phpEx, $phpbb_extension_manager;
global $phpbb_extension_manager;
$finder = $phpbb_extension_manager->get_finder();

View File

@@ -607,7 +607,7 @@ class auth_admin extends \phpbb\auth\auth
*/
function display_role_mask(&$hold_ary)
{
global $db, $template, $user, $phpbb_root_path, $phpbb_admin_path, $phpEx;
global $db, $template, $user, $phpbb_root_path, $phpEx;
global $phpbb_container;
if (!sizeof($hold_ary))