mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-03 07:18:08 +02:00
Code Issues Releases Wiki Activity

[ticket/security/211] Only run make_clickable() on URL type profile fields

Browse Source 
SECURITY-211
This commit is contained in:
Marc Alexander
2017-07-23 10:40:30 +02:00
parent 882a3c3831
commit 2749bfe26c
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
phpBB/phpbb/profilefields/type/type_string_common.php
View File

@@ -108,7 +108,6 @@ abstract class type_string_common extends type_base
return null; return null;
} }
$field_value = make_clickable($field_value);
$field_value = censor_text($field_value); $field_value = censor_text($field_value);
$field_value = bbcode_nl2br($field_value); $field_value = bbcode_nl2br($field_value);
return $field_value; return $field_value;

15
phpBB/phpbb/profilefields/type/type_url.php
View File

@@ -71,4 +71,19 @@ class type_url extends type_string
return false; return false;
} }
/**
* {@inheritDoc}
*/
public function get_profile_value($field_value, $field_data)
{
if (!preg_match('#^' . get_preg_expression('url_http') . '$#iu', $field_value))
{
return null;
}
$field_value = make_clickable($field_value);
return parent::get_profile_value($field_value, $field_data);
}
} }