mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-31 22:10:45 +02:00
Code Issues Releases Wiki Activity

[feature/oauth] Clean up TODOs

Browse Source 
PHPBB3-11673
This commit is contained in:
Joseph Warner
2013-08-24 17:14:30 -04:00
parent de17d5bdcc
commit 27ba57747a
6 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
phpBB/phpbb/auth/provider/oauth/oauth.php
View File

@@ -201,8 +201,7 @@ class phpbb_auth_provider_oauth extends phpbb_auth_provider_base
if (!$row)
{
// TODO: Update exception type and change it to language constant
throw new Exception('Invalid entry in ' . $this->auth_provider_oauth_token_account_assoc);
throw new Exception('AUTH_PROVIDER_OAUTH_ERROR_INVALID_ENTRY');
}
// Update token storage to store the user_id
@@ -216,7 +215,6 @@ class phpbb_auth_provider_oauth extends phpbb_auth_provider_base
);
} else {
$url = $service->getAuthorizationUri();
// TODO: modify $url for the appropriate return points
header('Location: ' . $url);
}
}

5
phpBB/phpbb/auth/provider/oauth/service/bitly.php
View File

@@ -67,7 +67,7 @@ class phpbb_auth_provider_oauth_service_bitly extends phpbb_auth_provider_oauth_
if (!($this->service_provider instanceof \OAuth\OAuth2\Service\Bitly))
{
// TODO: make exception class and use language constant
throw new Exception('Invalid service provider type');
throw new Exception('AUTH_PROVIDER_OAUTH_ERROR_INVALID_SERVICE_TYPE');
}
// This was a callback request from bitly, get the token
@@ -87,8 +87,7 @@ class phpbb_auth_provider_oauth_service_bitly extends phpbb_auth_provider_oauth_
{
if (!($this->service_provider instanceof \OAuth\OAuth2\Service\Bitly))
{
// TODO: make exception class and use language constant
throw new Exception('Invalid service provider type');
throw new Exception('AUTH_PROVIDER_OAUTH_ERROR_INVALID_SERVICE_TYPE');
}
// Send a request with it

2
phpBB/phpbb/auth/provider/oauth/service/facebook.php
View File

@@ -67,7 +67,7 @@ class phpbb_auth_provider_oauth_service_facebook extends phpbb_auth_provider_oau
if (!($this->service_provider instanceof \OAuth\OAuth2\Service\Facebook))
{
// TODO: make exception class and use language constant
throw new Exception('Invalid service provider type');
throw new Exception('AUTH_PROVIDER_OAUTH_ERROR_INVALID_SERVICE_TYPE');
}
// This was a callback request, get the token

6
phpBB/phpbb/auth/provider/oauth/service/google.php
View File

@@ -77,8 +77,7 @@ class phpbb_auth_provider_oauth_service_google extends phpbb_auth_provider_oauth
{
if (!($this->service_provider instanceof \OAuth\OAuth2\Service\Google))
{
// TODO: make exception class and use language constant
throw new Exception('Invalid service provider type');
throw new Exception('AUTH_PROVIDER_OAUTH_ERROR_INVALID_SERVICE_TYPE');
}
// This was a callback request, get the token
@@ -98,8 +97,7 @@ class phpbb_auth_provider_oauth_service_google extends phpbb_auth_provider_oauth
{
if (!($this->service_provider instanceof \OAuth\OAuth2\Service\Google))
{
// TODO: make exception class and use language constant
throw new Exception('Invalid service provider type');
throw new Exception('AUTH_PROVIDER_OAUTH_ERROR_INVALID_SERVICE_TYPE');
}
// Send a request with it