mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-03-13 20:28:44 +01:00
Code Issues Releases Wiki Activity

[ticket/13612] Always display success message if extension was enabled

Browse Source 
An error will already be triggered if enable_step() is not successful.
Redirecting for no obvious reason will just confuse users.

PHPBB3-13612
This commit is contained in:
Marc Alexander 2015-02-14 23:32:17 +01:00
parent 8314ce6871
commit 27cfda74fc
2 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
phpBB/includes/acp/acp_extensions.php
View File

@ -174,11 +174,6 @@ class acp_extensions
trigger_error($user->lang['EXTENSION_NOT_ENABLEABLE'] . adm_back_link($this->u_action), E_USER_WARNING);
}
if ($phpbb_extension_manager->is_enabled($ext_name))
{
redirect($this->u_action);
}
try
{
while ($phpbb_extension_manager->enable_step($ext_name))

9
tests/test_framework/phpbb_functional_test_case.php
View File

@ -422,14 +422,7 @@ class phpbb_functional_test_case extends phpbb_test_case
$meta_refresh = $crawler->filter('meta[http-equiv="refresh"]');
}
if (!empty($meta_refresh))
{
$this->assertContainsLang('EXTENSIONS_ADMIN', $crawler->filter('.main > h1')->text());
}
else
{
$this->assertContainsLang('EXTENSION_ENABLE_SUCCESS', $crawler->filter('div.successbox')->text());
}
$this->assertContainsLang('EXTENSION_ENABLE_SUCCESS', $crawler->filter('div.successbox')->text());
$this->logout();
}