mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-08-01 14:30:32 +02:00
Code Issues Releases Wiki Activity

#4760

Browse Source 
No more eval()


git-svn-id: file:///svn/phpbb/trunk@6505 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Dominik Dröscher
2006-10-16 13:42:17 +00:00
parent 1d1e6d4603
commit 2917956fe5
2 changed files with 32 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
phpBB/styles/subSilver/template/editor.js
View File

@@ -23,7 +23,7 @@ var is_mac = (clientPC.indexOf('mac') != -1);
*/
function helpline(help)
{
document.forms[form_name].helpbox.value = eval(help + '_help');
document.forms[form_name].helpbox.value = help_line[help];
}
/**
@@ -123,9 +123,11 @@ function insert_text(text, spaces, popup)
{
var textarea;
if (!popup) {
if (!popup)
{
textarea = document.forms[form_name].elements[text_name];
} else {
} else
{
textarea = opener.document.forms[form_name].elements[text_name];
}
if (spaces)
@@ -172,11 +174,11 @@ function addquote(post_id, username)
if (document.all)
{
eval('divarea = document.all.' + message_name + ';');
divarea = document.all[message_name];
}
else
{
eval("divarea = document.getElementById('" + message_name + "');");
divarea = document.getElementById(message_name);
}
// Get text selection - not only the post content :(
@@ -239,11 +241,11 @@ function bbstyle(bbnumber)
{
butnumber = arraypop(bbcode) - 1;
document.forms[form_name].elements[text_name].value += bbtags[butnumber + 1];
buttext = eval('document.forms[form_name].addbbcode' + butnumber + '.value');
buttext = document.forms[form_name]['addbbcode' + butnumber].value;
if (buttext != '[*]')
{
eval('document.forms[form_name].addbbcode' + butnumber + '.value ="' + buttext.substr(0,(buttext.length - 1)) + '"');
document.forms[form_name]['addbbcode' + butnumber].value = buttext.substr(0,(buttext.length - 1));
}
}
@@ -351,11 +353,11 @@ function bbstyle(bbnumber)
insert_text(bbtags[butnumber]);
}
buttext = eval('document.forms[form_name].addbbcode' + butnumber + '.value');
buttext = document.forms[form_name]['addbbcode' + butnumber].value;
if (bbtags[butnumber] != '[*]')
{
eval('document.forms[form_name].addbbcode' + butnumber + '.value ="' + buttext.substr(0,(buttext.length - 1)) + '"');
document.forms[form_name]['addbbcode' + butnumber].value = buttext.substr(0,(buttext.length - 1));
}
imageTag = false;
}
@@ -391,7 +393,7 @@ function bbstyle(bbnumber)
if (bbtags[bbnumber] != '[*]')
{
arraypush(bbcode, bbnumber + 1);
eval('document.forms[form_name].addbbcode'+bbnumber+'.value += "*"');
document.forms[form_name]['addbbcode' + bbnumber].value += "*";
}
document.forms[form_name].elements[text_name].focus();
@@ -491,4 +493,4 @@ function colorPalette(dir, width, height)
}
}
document.writeln('</table>');
}
}