[ticket/16649] Add compiler pass to make all services public

This also handles BC for phpBB extensions

PHPBB3-16639

phpBB/config/default/container/services.yml

@@ -36,8 +36,6 @@ imports:
     - { resource: parameters.yml }
 
 services:
-    _defaults: { public: true }
-
     cache:
         class: phpbb\cache\service
         arguments:

phpBB/config/default/container/services_attachment.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     attachment.delete:
         class: phpbb\attachment\delete
         shared: false

phpBB/config/default/container/services_auth.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
 # ----- Auth management -----
     auth:
         class: phpbb\auth\auth

phpBB/config/default/container/services_avatar.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     avatar.manager:
         class: phpbb\avatar\manager
         arguments:

phpBB/config/default/container/services_captcha.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     captcha.factory:
         class: phpbb\captcha\factory
         arguments:

phpBB/config/default/container/services_console.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     console.exception_subscriber:
         class: phpbb\console\exception_subscriber
         arguments:

phpBB/config/default/container/services_content.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     content.visibility:
         class: phpbb\content_visibility
         arguments:

phpBB/config/default/container/services_cron.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     cron.manager:
         class: phpbb\cron\manager
         arguments:

phpBB/config/default/container/services_db.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     dbal.conn:
         class: phpbb\db\driver\factory
         arguments:

phpBB/config/default/container/services_event.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     dispatcher:
         class: phpbb\event\dispatcher
         arguments:

phpBB/config/default/container/services_extensions.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     ext.manager:
         class: phpbb\extension\manager
         arguments:

phpBB/config/default/container/services_feed.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     phpbb.feed.controller:
         class: phpbb\feed\controller\feed
         arguments:

phpBB/config/default/container/services_files.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     files.factory:
         class: phpbb\files\factory
         arguments:

phpBB/config/default/container/services_filesystem.yml

@@ -2,8 +2,6 @@ parameters:
     core.filesystem.cache_temp_dir: '%core.cache_dir%tmp/'
 
 services:
-    _defaults: { public: true }
-
     filesystem:
         class: phpbb\filesystem\filesystem
 

phpBB/config/default/container/services_help.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     phpbb.help.manager:
         class: phpbb\help\manager
         arguments:

phpBB/config/default/container/services_http.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     http_kernel:
         class: Symfony\Component\HttpKernel\HttpKernel
         arguments:

phpBB/config/default/container/services_language.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     language.helper.language_file:
         class: phpbb\language\language_file_helper
         arguments:

phpBB/config/default/container/services_migrator.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
 # ----- Migrator -----
     migrator:
         class: phpbb\db\migrator

phpBB/config/default/container/services_mimetype_guesser.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     mimetype.guesser_collection:
         class: phpbb\di\service_collection
         arguments:

phpBB/config/default/container/services_module.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     module.manager:
         class: phpbb\module\module_manager
         arguments:

phpBB/config/default/container/services_notification.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     notification_manager:
         class: phpbb\notification\manager
         arguments:

phpBB/config/default/container/services_password.yml

@@ -5,8 +5,6 @@ parameters:
     passwords.driver.bcrypt_cost: 10
 
 services:
-    _defaults: { public: true }
-
 # ----- Password management -----
     passwords.manager:
         class: phpbb\passwords\manager

phpBB/config/default/container/services_php.yml

@@ -1,5 +1,3 @@
 services:
-    _defaults: { public: true }
-
     php_ini:
         class: bantu\IniGetWrapper\IniGetWrapper

phpBB/config/default/container/services_profilefield.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     profilefields.manager:
         class: phpbb\profilefields\manager
         arguments:

phpBB/config/default/container/services_report.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
 # ----- Report controller -----
     phpbb.report.controller:
         class: phpbb\report\controller\report

phpBB/config/default/container/services_routing.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     router:
         class: phpbb\routing\router
         arguments:

phpBB/config/default/container/services_storage.yml

@@ -1,5 +1,4 @@
 services:
-    _defaults: { public: true }
 
 # Storages
     storage.attachment:

phpBB/config/default/container/services_text_formatter.yml

@@ -4,8 +4,6 @@ parameters:
     text_formatter.cache.renderer.key: _text_formatter_renderer
 
 services:
-    _defaults: { public: true }
-
     text_formatter.acp_utils:
         class: phpbb\textformatter\s9e\acp_utils
         arguments:

phpBB/config/default/container/services_text_reparser.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     text_reparser.manager:
         class: phpbb\textreparser\manager
         arguments:

phpBB/config/default/container/services_twig.yml

@@ -2,8 +2,6 @@ parameters:
     core.template.cache_path: '%core.cache_dir%twig/'
 
 services:
-    _defaults: { public: true }
-
     template.twig.environment:
         class: phpbb\template\twig\environment
         arguments:

phpBB/config/default/container/services_twig_extensions.yml

@@ -1,8 +1,6 @@
 # Twig extensions not needed by the installer
 
 services:
-    _defaults: { public: true }
-
     template.twig.extensions.icon:
         class: phpbb\template\twig\extension\icon
         arguments:

phpBB/config/default/container/services_ucp.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     phpbb.ucp.controller.reset_password:
         class: phpbb\ucp\controller\reset_password
         arguments:

phpBB/config/default/container/services_user.yml

@@ -1,6 +1,4 @@
 services:
-    _defaults: { public: true }
-
     acl.permissions:
         class: phpbb\permissions
         arguments: