[ticket/16649] Add compiler pass to make all services public

This also handles BC for phpBB extensions

PHPBB3-16639

tests/controller/config/services.yml

@@ -1,4 +1,3 @@
 services:
-    _defaults: { public: true }
     core_foo.controller:
         class: phpbb\controller\foo

tests/controller/ext/vendor2/bar/config/services.yml

@@ -1,4 +1,3 @@
 services:
-    _defaults: { public: true }
     bar.controller:
         class: bar\controller

tests/controller/ext/vendor2/foo/config/services.yml

@@ -1,4 +1,3 @@
 services:
-    _defaults: { public: true }
     foo.controller:
         class: foo\controller

tests/di/fixtures/config/production/container/environment.yml

@@ -5,7 +5,6 @@ parameters:
     tables.acl_roles: '%core.table_prefix%acl_roles'
 
 services:
-    _defaults: { public: true }
     config.php:
         synthetic: true
 

tests/di/fixtures/config/test/container/environment.yml

@@ -5,7 +5,6 @@ parameters:
     tables.acl_roles: '%core.table_prefix%acl_roles'
 
 services:
-    _defaults: { public: true }
     config.php:
         synthetic: true
 

tests/di/fixtures/other_config/production/container/environment.yml

@@ -2,7 +2,6 @@ parameters:
     other_config: true
 
 services:
-    _defaults: { public: true }
     config.php:
         synthetic: true
 

tests/di/fixtures/other_config/test/container/environment.yml

@@ -2,7 +2,6 @@ parameters:
     other_config: true
 
 services:
-    _defaults: { public: true }
     config.php:
         synthetic: true
 

tests/functional/fixtures/ext/foo/bar/config/services.yml

@@ -1,5 +1,4 @@
 services:
-    _defaults: { public: true }
     foo_bar.controller:
         class: foo\bar\controller\controller
         arguments:

tests/functional/fixtures/ext/foo/foo/config/services.yml

@@ -1,4 +1,3 @@
 services:
-    _defaults: { public: true }
     foo_foo.controller:
         class: foo\foo\controller\controller

tests/notification/fixtures/services_notification.yml

@@ -2,7 +2,6 @@ imports:
     - { resource: ../../../phpBB/config/default/container/services_notification.yml }
 
 services:
-    _defaults: { public: true }
     notification_manager:
         synthetic: true