mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-29 13:00:26 +02:00
Code Issues Releases Wiki Activity

[feature/ajax] Use attr('data-foo') instead of data('foo')

Browse Source 
data() is slower and does additional unwanted things like
caching and type conversion. Just reading the value is safer.

PHPBB3-10270
This commit is contained in:
Igor Wiedler
2012-02-08 18:42:21 +01:00
parent 265907b115
commit 30888ff2a0
3 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
phpBB/assets/javascript/core.js
View File

@@ -31,7 +31,7 @@ phpbb.loading_alert = function() {
setTimeout(function() {
if (loading_alert.is(':visible'))
{
phpbb.alert($('#phpbb_alert').data('l-err'), $('#phpbb_alert').data('l-timeout-processing-req'));
phpbb.alert($('#phpbb_alert').attr('data-l-err'), $('#phpbb_alert').attr('data-l-timeout-processing-req'));
}
}, 5000);
});
@@ -125,7 +125,7 @@ phpbb.confirm = function(msg, callback, fadedark) {
e.stopPropagation();
return true;
});
var click_handler = function() {
var res = this.className === 'button1';
var fade = (typeof fadedark !== 'undefined' && !fadedark && res) ? div : dark;
@@ -236,7 +236,7 @@ phpbb.ajaxify = function(options, refresh, callback) {
elements.click(function() {
var action, data, path, that = this, $this = $(this);
if ($this.data('ajax') == false)
if ($this.attr('data-ajax') == false)
{
return true;
}
@@ -385,8 +385,8 @@ phpbb.add_ajax_callback = function(id, callback)
*/
phpbb.add_ajax_callback('alt_text', function(el) {
el = $(el);
var alt_text = el.data('alt-text');
el.data('alt-text', el.text());
var alt_text = el.attr('data-alt-text');
el.attr('data-alt-text', el.text());
el.text(el[0].title = alt_text);
});