mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-31 22:10:45 +02:00
Code Issues Releases Wiki Activity

[feature/ajax] Use attr('data-foo') instead of data('foo')

Browse Source 
data() is slower and does additional unwanted things like
caching and type conversion. Just reading the value is safer.

PHPBB3-10270
This commit is contained in:
Igor Wiedler
2012-02-08 18:42:21 +01:00
parent 265907b115
commit 30888ff2a0
3 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
phpBB/styles/prosilver/template/ajax.js
View File

@@ -4,7 +4,7 @@
// This callback finds the post from the delete link, and removes it.
phpbb.add_ajax_callback('post_delete', function() {
var el = $(this);
if (el.data('refresh') === undefined)
if (el.attr('data-refresh') === undefined)
{
var post_id = el[0].href.split('&p=')[1];
el.parents('#p' + post_id).fadeOut(function() {
@@ -44,11 +44,11 @@ phpbb.add_ajax_callback('zebra', function(res) {
$('[data-ajax]').each(function() {
var $this = $(this), ajax = $this.data('ajax');
var $this = $(this), ajax = $this.attr('data-ajax');
if (ajax !== 'false')
{
var fn = (ajax !== 'true') ? ajax : null;
phpbb.ajaxify({selector: this}, $this.data('refresh') !== undefined, fn);
phpbb.ajaxify({selector: this}, $this.attr('data-refresh') !== undefined, fn);
}
});